Bug #78116

extbase setting statement directly should support Doctrine\DBAL\Statement

Added by Andreas Allacher over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
Start date:
2016-09-29
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

With the change to doctrine DBAL extbase direct query
should also support "\Doctrine\DBAL\Statement" as prepared statements
instead of only "\TYPO3\CMS\Core\Database\PreparedStatement"
especially as that class uses DatabaseConnection which is deprecated.

See the if condition in getObjectDataByRawQuery
https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php#l399

which doesn't check for possible doctrine prepared statement.

Associated revisions

Revision 25949707 (diff)
Added by Benni Mack about 3 years ago

[FEATURE] Add Support for Doctrine DBAL Queries in Extbase

To fully utilize Extbase in conjunction with Doctrine DBAL,
Extbases' StorageBackend now supports native QueryBuilder
and Doctrine DBAL Statements, which can be used for prepared
statements.

Resolves: #78116
Releases: master
Change-Id: I73b5a9588465e345029b7985327fb0cd0d7875df
Reviewed-on: https://review.typo3.org/50178
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Wouter Wolters over 3 years ago

Extbase is not finished yet with DBAL migration. See https://review.typo3.org/#/c/49584/

#2 Updated by Andreas Allacher over 3 years ago

Ah. Didn't know it wasn't finished yet.
However, the mentioned review doesn't take care of this either (yet).

#3 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178

#4 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178

#5 Updated by Benni Mack over 3 years ago

  • Target version changed from 8.4 to 8.5

#6 Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178

#7 Updated by Gerrit Code Review about 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178

#8 Updated by Gerrit Code Review about 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178

#9 Updated by Gerrit Code Review about 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178

#10 Updated by Gerrit Code Review about 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178

#11 Updated by Benni Mack about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Riccardo De Contardi over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF