Bug #78300

Installtoool Autoupdate never checks if symlinks can be created

Added by David Bruchmann over 3 years ago. Updated about 2 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2016-10-14
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The Installtool-Autoupdate never checks if symlinks can be created and therefore an update can fail with a non-working site.
Existing symlinks to index.php and typo3_src are deleted as part of the update and with the target to create them new. Depending on user-rights on the server there is no guarantee that existence of symlinks also allows creation of those. So an update can fail in the last steps when it's tried to crate the symlinks without success.

For the case that symlinks can't be created it's possible that it can be repaired without symlinks:
1) the symlink to typo3 still exists, then it's enough to rename 'typo3_src-x.x.xx' to 'typo3_src' and to copy index.php in the main-directory
2) the symlink to typo3 either never exists or still exists, but was wrongly showing directly to typo3_src-x.x.xx/typo3 (the older version of TYPO3):
Then the steps in 1) have to be done but additionally /typo3_src-x.x.xx/typo3 has to be copied to /typo3

For the case that FTP-Access never exists the installation is not working anymore and the update leads to undesired results and consequences.

If/When any test concerning symlinks in the install-tool will be included it would be nice still having the option to chose the options in the list above for the case that new symlinks can't be created.

Associated revisions

Revision 01048ed0 (diff)
Added by Susanne Moog 3 months ago

[TASK] Check symbolic link creation before auto updating

The core updater has been adjusted to not only check file write rights,
but also the ability to create symbolic links before attempting to
run the updater.

Resolves: #78300
Releases: master, 9.5
Change-Id: If14f41d5c0e3a73c883ec49ef601d9d19684f4ed
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63617
Reviewed-by: Andreas Fernandez <>
Reviewed-by: David Bruchmann <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Benni Mack <>
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Benni Mack <>

Revision 306ddc70 (diff)
Added by Susanne Moog 3 months ago

[TASK] Check symbolic link creation before auto updating

The core updater has been adjusted to not only check file write rights,
but also the ability to create symbolic links before attempting to
run the updater.

Resolves: #78300
Releases: master, 9.5
Change-Id: If14f41d5c0e3a73c883ec49ef601d9d19684f4ed
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63656
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63617

#2 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63617

#3 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63617

#4 Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63617

#5 Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63656

#6 Updated by Susanne Moog 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF