Project

General

Profile

Actions

Bug #78327

closed

isHiddenPalette removes 'form-section' class

Added by Jérémie Roulin over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2016-10-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

Hi,
If I hide a palette with "isHiddenPalette" param, the next palette is displayed with a top border. In fact, the isHiddenPalette state removes 'form-section' class that is needed to remove the top border.
To fix it I've changed the fieldSetWrap method in PaletteAndSingleContainer class like this :

    protected function fieldSetWrap($content, $paletteHidden = false, $label = '')
    {
        $fieldSetClass = 'form-section';
        if ($paletteHidden) {
            $fieldSetClass .= ' hide';
        }

        ...
    }

Can someone commit this little change?

Thanks,
Jérémie

Actions #1

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50295

Actions #2

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50296

Actions #3

Updated by Eric Chavaillaz over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF