Project

General

Profile

Actions

Bug #78529

closed

Exception thrown in Install Tool > Upgrade Wizard

Added by Frank Nägler over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Install Tool
Target version:
Start date:
2016-11-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In case of wrong ext_tables.php file - e.g. a missing comma - the UpgradeWizard in Install tool throws an exception.

This can be tested, by removing a comma after a column definition.

example:
no error, SQL is correct

CREATE TABLE tx_foo_bar (
  uid int(11) NOT NULL auto_increment,
  pid int(11) DEFAULT '0' NOT NULL,
  tstamp int(11) DEFAULT '0' NOT NULL,
  crdate int(11) DEFAULT '0' NOT NULL,
  title tinytext,
  description text,
  content text,

  PRIMARY KEY (uid),
  KEY parent (pid)
);

error, SQL is NOT correct, missing comma after column title

CREATE TABLE tx_foo_bar (
  uid int(11) NOT NULL auto_increment,
  pid int(11) DEFAULT '0' NOT NULL,
  tstamp int(11) DEFAULT '0' NOT NULL,
  crdate int(11) DEFAULT '0' NOT NULL,
  title tinytext
  description text,
  content text,

  PRIMARY KEY (uid),
  KEY parent (pid)
);

To reproduce this issue:
1) use any ext_tables.sql file and remove a comma.
2) Go to Install Tool
3) Click on Upgrade Wizard
=> Exception thrown


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #78235: Install tool may crash if ext_tables.sql cannot be parsedClosedXavier Perseguers2016-10-11

Actions
Actions #1

Updated by Gerrit Code Review over 7 years ago

  • Status changed from In Progress to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50469

Actions #2

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50469

Actions #3

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50469

Actions #4

Updated by Frank Nägler over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF