Bug #78730
closedrtehtmlarea: isRequiredClass check is incorrect
100%
Description
Given the following TSConfig:
RTE {
classes {
btn-default {
name = Default Button
requires = btn
}
btn-primary {
name = Primary Button
requires = btn
}
btn.selectable = 0
}
}
The incorrect isRequiredClass check causes the btn class to be
removed from the RTE toolbarbuttons. This happens because it's
considered unneded in DOM.removeClass(), which is called by
DOM.addClass() (to remove incompatible classes).
The check in isRequiredClass was probably copied from
some classesRequired lookups, but forgot to inverse the
class that's searched for.
This also fixes the RTE to properly remove the selectable=0 class
(e.g. btn), when a class that requires the aformentioned is removed
(e.g. btn-primary).
(Note: To avoid further incompatibilities between classes configured
for the RTE content and the RTE toolbar, it should be consided to not
render RTE Buttons using DOM.addClass())
Updated by Gerrit Code Review about 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50692
Updated by Gerrit Code Review almost 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50692
Updated by Gerrit Code Review almost 8 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50893
Updated by Benjamin Franzke almost 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 30d9a1c645e3c2962b5960fa6b6727a168d0c0d5.