Project

General

Profile

Actions
Copy link

Bug #78844

closed

HTML5: use self-closing tags only if allowed

Added by Markus Mächler almost 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Markus Mächler
Category:
Frontend
Target version:
Candidate for patchlevel
Start date:
2016-11-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

In the frontend rendering of RTE content, empty tags should only be converted to self-closing tags if allowed by the HTML5 standard.
The Problem ist that e.g. 

<a id="myspecialanchor"></a>

is converted to

<a id="myspecialanchor" />

which will result in the subsequent content being rendered as a link, too (at least in Google Chrome).

This Problem exists in TYPO3 7.6 and 8.

This is because only specific tags may be self-closing according to the HTML5 specification:

https://www.w3.org/TR/html5/syntax.html#void-elements

Void elements: area, base, br, col, embed, hr, img, input, keygen, link, meta, param, source, track, wbr

The following line should be fixed:

https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#L4964

Moreover, the a notice should be added to the todo-comment in following line

https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#L4074

Actions
Copy link
 #1

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50812

Actions
Copy link
 #2

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50889

Actions
Copy link
 #3

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50889

Actions
Copy link
 #4

Updated by Gerrit Code Review almost 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50812

Actions
Copy link
 #5

Updated by Gerrit Code Review almost 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50889

Actions
Copy link
 #6

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50812

Actions
Copy link
 #7

Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50812

Actions
Copy link
 #8

Updated by Oliver Hader about 7 years ago

  • Category changed from 1050 to Frontend
Actions
Copy link
 #9

Updated by Gerrit Code Review almost 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50812

Actions
Copy link
 #10

Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55664

Actions
Copy link
 #11

Updated by Anonymous almost 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #12

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF