Project

General

Profile

Actions

Task #78854

closed

Remove obsolete CLI check from reports config

Added by Alexander Stehlik over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Reports
Target version:
Start date:
2016-12-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
easy
Sprint Focus:
On Location Sprint

Description

The condition that checks for CLI mode in typo3/sysext/install/ext_tables.php is invalid:

// Only add the environment status report if not in CLI mode
if (!(TYPO3_REQUESTTYPE & TYPO3_REQUESTTYPE_CLI)) {
    $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['reports']['tx_reports']['status']['providers']['system'][] = \TYPO3\CMS\Install\Report\EnvironmentStatusReport::class;
}

The EnvironmentStatusReport is active for CLI only at the moment.

The check can be removed because the problematic checks were already fixed in #78786.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #78786: disable trustedHostsPattern check for Scheduler Task "System Status Update (reports)" (false negative)ClosedMarkus Sommer2016-11-24

Actions
Actions #1

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50825

Actions #2

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50825

Actions #3

Updated by Alexander Stehlik over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Gerrit Code Review over 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50874

Actions #5

Updated by Alexander Stehlik over 7 years ago

  • Status changed from Under Review to Resolved
Actions #6

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF