Task #78854

Remove obsolete CLI check from reports config

Added by Alexander Stehlik almost 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Category:
Reports
Target version:
Start date:
2016-12-01
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
easy
Sprint Focus:
On Location Sprint

Description

The condition that checks for CLI mode in typo3/sysext/install/ext_tables.php is invalid:

// Only add the environment status report if not in CLI mode
if (!(TYPO3_REQUESTTYPE & TYPO3_REQUESTTYPE_CLI)) {
    $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['reports']['tx_reports']['status']['providers']['system'][] = \TYPO3\CMS\Install\Report\EnvironmentStatusReport::class;
}

The EnvironmentStatusReport is active for CLI only at the moment.

The check can be removed because the problematic checks were already fixed in #78786.


Related issues

Related to TYPO3 Core - Bug #78786: disable trustedHostsPattern check for Scheduler Task "System Status Update (reports)" (false negative) Closed 2016-11-24

Associated revisions

Revision 8b18bcbe (diff)
Added by Alexander Stehlik almost 4 years ago

[BUGFIX] Re-enable environment status report in Backend

The condition that checks for CLI mode in the ext_tables.php of
the install tool is fixed.

The EnvironmentStatusReport is now active in the Backend and
not on CLI.

The additional checks added in #78786 are not required any more
and are reverted.

Change-Id: I4d364fc08c68c7c25d9210c08b813247bee7d47f
Resolves: #78854
Relates: #78786
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50825
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision ebbfb0ae (diff)
Added by Alexander Stehlik almost 4 years ago

Revert "[BUGFIX] Disable not required checks on cli"

This reverts commit c02d4e37e44d12125969657e4e5706ff68eb1808.

The condition for checking for CLI mode in ext_tables.php of
the install tool is correct in the 7.6 branch.

The additional checks are not required.

Change-Id: I4d364fc08c68c7c25d9210c08b813247bee7d47f
Resolves: #78854
Relates: #78786
Reviewed-on: https://review.typo3.org/50874
Tested-by: TYPO3com <>
Reviewed-by: Markus Sommer <>
Tested-by: Markus Sommer <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review almost 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50825

#2 Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50825

#3 Updated by Alexander Stehlik almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review almost 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50874

#5 Updated by Alexander Stehlik almost 4 years ago

  • Status changed from Under Review to Resolved

#6 Updated by Riccardo De Contardi about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF