Bug #78786

disable trustedHostsPattern check for Scheduler Task "System Status Update (reports)" (false negative)

Added by Oliver Eglseder almost 3 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Reports
Target version:
-
Start date:
2016-11-24
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
On Location Sprint

Description

"System Status Update (reports)" is the Scheduler Task, which checks for all statuses, including the trusted host pattern.
The actual executed method, which always adds a failure message is \TYPO3\CMS\Install\SystemEnvironment\SetupCheck::checkTrustedHostPattern.
It passes $_SERVER['HTTP_HOST'] to \TYPO3\CMS\Core\Utility\GeneralUtility::hostHeaderValueMatchesTrustedHostsPattern, which won't be set on the command line.

This produces the false negative in the status update email:

Issues:
[ERR] System environment check - 1 Test(s)
  1. Trusted hosts pattern mismatch: error

Related issues

Related to TYPO3 Core - Task #78854: Remove obsolete CLI check from reports config Closed 2016-12-01

Associated revisions

Revision 88850144 (diff)
Added by Markus Sommer almost 3 years ago

[BUGFIX] Disable not required checks on cli

  • $_SERVER['HTTP_HOST'] is not avalible on cli
  • Mostly max_execution_time is not set on cli

Resolves: #78786
Releases: master, 7.6
Change-Id: If19dab862e2762fab5fec113c93eba80f75a4aaf
Reviewed-on: https://review.typo3.org/50777
Tested-by: TYPO3com <>
Reviewed-by: Oliver Eglseder <>
Tested-by: Oliver Eglseder <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision c02d4e37 (diff)
Added by Markus Sommer almost 3 years ago

[BUGFIX] Disable not required checks on cli

  • $_SERVER['HTTP_HOST'] is not avalible on cli
  • Mostly max_execution_time is not set on cli

Resolves: #78786
Releases: master, 7.6
Change-Id: If19dab862e2762fab5fec113c93eba80f75a4aaf
Reviewed-on: https://review.typo3.org/50818
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Markus Sommer almost 3 years ago

  • Assignee set to Markus Sommer

i can reproduce this

#2 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50777

#3 Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50777

#4 Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50777

#5 Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50777

#6 Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50777

#7 Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50818

#8 Updated by Markus Sommer almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Anja Leichsenring almost 3 years ago

  • Sprint Focus set to On Location Sprint

#10 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF