Bug #79128

"Record history" is shown, even if hidden with TSConfig

Added by Soren Malling about 1 month ago. Updated about 1 month ago.

Status:Under Review Start date:2017-01-01
Priority:Should have Due date:
Assigned To:- % Done:

0%

Category:Backend User Interface Spent time: -
Target version:-
TYPO3 Version:8 Complexity:
PHP Version:7.0 Is Regression:No
Tags: Sprint Focus:

Description

The tsconfig

options.showHistory = 0

is not respected in TYPO3\CMS\Backend\Controller\EditDocumentController in the getButtons() method in the making of the buttonbar.

Actually, a "Record History" buttons is being rendered twice but the TSconfig condition is only checked once.

In the first case, a condition only checks if there is any history

https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369

and then renders the button.

On line 1400

https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369

the condition is checked with the "getNewIconMode" method and respect if it's hidden

History

#1 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51090

Also available in: Atom PDF