Bug #79128

"Record history" is shown, even if hidden with TSConfig

Added by Soren Malling over 1 year ago. Updated 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2017-01-01
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The tsconfig

options.showHistory = 0

is not respected in TYPO3\CMS\Backend\Controller\EditDocumentController in the getButtons() method in the making of the buttonbar.

Actually, a "Record History" buttons is being rendered twice but the TSconfig condition is only checked once.

In the first case, a condition only checks if there is any history

https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369

and then renders the button.

On line 1400

https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369

the condition is checked with the "getNewIconMode" method and respect if it's hidden

Associated revisions

Revision ae6338fe (diff)
Added by Tymoteusz Motylewski 2 months ago

[BUGFIX] Respect TSconfig option showHistory

The TSconfig `options.showHistory` is not respected inside the core.
Add checks for list view and context menu.

Inside EditDocumentController the "Record History"
button is being rendered twice but the TSconfig
condition is only checked once.

Resolves: #79128
Releases: master, 8.7
Change-Id: Ifa884be5882772e8c267a7eb8036c53cf987bcfb
Reviewed-on: https://review.typo3.org/51090
Tested-by: TYPO3com <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

Revision 211383c5 (diff)
Added by Tymoteusz Motylewski 2 months ago

[BUGFIX] Respect TSconfig option showHistory

The TSconfig `options.showHistory` is not respected inside the core.
Add checks for list view and context menu.

Inside EditDocumentController the "Record History"
button is being rendered twice but the TSconfig
condition is only checked once.

Resolves: #79128
Releases: master, 8.7
Change-Id: Ifa884be5882772e8c267a7eb8036c53cf987bcfb
Reviewed-on: https://review.typo3.org/55658
Tested-by: TYPO3com <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51090

#2 Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51090

#3 Updated by Gerrit Code Review 6 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51090

#4 Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51090

#5 Updated by Gerrit Code Review 2 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51090

#6 Updated by Gerrit Code Review 2 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51090

#7 Updated by Tymoteusz Motylewski 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Gerrit Code Review 2 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55658

#9 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55658

#10 Updated by Tymoteusz Motylewski 2 months ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF