Project

General

Profile

Actions
Copy link

Bug #79245

closed

extbase FlexFormService: keys with dot inside get lost

Added by Christian Weiske almost 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2017-01-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
On Location Sprint

Description

TYPO3\CMS\Extbase\Service\FlexFormService::walkFlexFormNode() loses keys with . dot notation:

<itemType index="_arrayContainer">
  <el>
    <field index="dot.one">
      <value index="vDEF">dot.one-Value</value>
    </field>
    <field index="dot.two">
      <value index="vDEF">dot.two-Value</value>
    </field>
  </el>
</itemType>

Results in:

'dot' => Array &4 (
    'two' => 'dot.two-Value'
)

This happens with TYPO3 7.6.15 and PHP 7.0.8.

Can be tested by applying the attached patch to the unit test file and running:

$ ./bin/phpunit -c typo3/sysext/core/Build/UnitTests.xml  typo3/sysext/extbase/Tests/Unit/Service/FlexFormServiceTest.php

Files

Download all files
FlexFormServiceTest.php.diff (1.32 KB) FlexFormServiceTest.php.diff Christian Weiske, 2017-01-10 13:41
FlexFormService.php.diff (959 Bytes) FlexFormService.php.diff Christian Weiske, 2017-01-10 14:15
Actions
Copy link
 #1

Updated by Christian Weiske almost 8 years ago

Also happens with PHP 5.6.29 and PHP 7.1.0, so it's not the PHP reference bug https://bugs.php.net/bug.php?id=72543.

Actions
Copy link
 #2

Updated by Christian Weiske almost 8 years ago

Problem was that the complete subarray got replaced.

Actions
Copy link
 #3

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51236

Actions
Copy link
 #4

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51236

Actions
Copy link
 #5

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51236

Actions
Copy link
 #6

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51236

Actions
Copy link
 #7

Updated by Benni Mack almost 7 years ago

  • Sprint Focus set to On Location Sprint
Actions
Copy link
 #8

Updated by Gerrit Code Review almost 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51236

Actions
Copy link
 #9

Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54806

Actions
Copy link
 #10

Updated by Anonymous almost 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #11

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF