Project

General

Profile

Actions

Bug #79296

closed

rootline fills in records from all workspaces in Live Workspace

Added by Franz Holzinger over 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2017-01-12
Due date:
% Done:

100%

Estimated time:
2.00 h
TYPO3 Version:
8
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

This is the bugfix for the phenomenon when a header image is not shown when workspaces are used. An exception Object TYPO3\CMS\Core\Resource\Exception\ResourceDoesNotExistException
is raised which aborts the further php execution. This is because in the later process pid <> -1 is checked, but the workspace records have pid = -1.

Reason:

The debug output of the rootline contains the records from the workspace.

Solution:

Add the enableFields where clause in order to check if workspaces and workspace preview is used.

Debug:

Application.php    78    handleRequest
Bootstrap.php    302    handleRequest
RequestHandler.php    140    determineId
TypoScriptFrontendController.php    1334    getRootLine
PageRepository.php    816    get
RootlineUtility.php    215    generateRootlineCache
RootlineUtility.php    367    getRecordArray
RootlineUtility.php    263    enrichWithRelationFields
RootlineUtility.php    325    exec_SELECTgetRows
DatabaseConnection.php    373    exec_SELECTquery
DatabaseConnection.php    308    myDebug
DatabaseConnection.php    817    callDebugger

Array
function/mode    Pg16 exec_SELECTgetRows(sys_file_reference) - RootlineUtility.php#263->enrichWithRelationFields // RootlineUtility.php#325->exec_SELECTgetRows // DatabaseConnection.php#373->exec_SELECTquery
SQL query    SELECT uid FROM sys_file_reference WHERE uid_foreign = 16 AND fieldname = 'media' AND tablenames = 'pages' AND sys_file_reference.hidden = 0 AND sys_file_reference.deleted=0 ORDER BY sorting_foreign
num_rows()    
Integer
2
debug_backtrace    call_user_func#34 // {closure}# // TYPO3\CMS\Frontend\Http\Application->run#33 // TYPO3\CMS\Core\Core\Bootstrap->handleRequest#78 // TYPO3\CMS\Frontend\Http\RequestHandler->handleRequest#302 // TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController->determineId#140 // TYPO3\CMS\Frontend\Page\PageRepository->getRootLine#1334 // TYPO3\CMS\Core\Utility\RootlineUtility->get#816 // TYPO3\CMS\Core\Utility\RootlineUtility->generateRootlineCache#215 // TYPO3\CMS\Core\Utility\RootlineUtility->getRecordArray#367 // TYPO3\CMS\Core\Utility\RootlineUtility->enrichWithRelationFields#263 // Geithware\DebugMysqlDb\Database\DatabaseConnection->exec_SELECTgetRows#325 // Geithware\DebugMysqlDb\Database\DatabaseConnection->exec_SELECTquery#373 // Geithware\DebugMysqlDb\Database\DatabaseConnection->myDebug#308
miliseconds    
Double
0.703

--------------------------

Array
pid    5
uid    16
t3ver_oid    0
t3ver_wsid    0
t3ver_state    0
title    Page Title
alias    
nav_title    Page Title
media    400,412
layout    0
hidden    0
starttime    0
endtime    0
fe_group    
extendToSubpages    0
doktype    1
TSconfig    
tsconfig_includes    
is_siteroot    0
mount_pid    0
mount_pid_ol    0
fe_login_mode    0
backend_layout_next_level    
tx_realurl_pathsegment    
tx_realurl_exclude    0
tx_realurl_pathoverride    0
categories    
getRecordArray $row Pos 3

Here the field 'media' has the sys_file_reference uids 400,412 which related to sys_file uid = 102. But 412 is only from the workspace. It should not be used in this case with Live Workspace.


Files

patch_79296.diff (947 Bytes) patch_79296.diff Franz Holzinger, 2017-01-13 11:13

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #79031: workspace Image/Text preview cannot find file referenceClosed2016-12-19

Actions
Actions #1

Updated by Franz Holzinger over 7 years ago

This patch fixes the issue.

Actions #2

Updated by Franz Holzinger over 7 years ago

See extension patch_workspaceimage which fixes this issue.

Actions #3

Updated by Riccardo De Contardi over 6 years ago

  • Category set to Workspaces
Actions #4

Updated by Alexander Opitz over 6 years ago

  • Status changed from New to Needs Feedback

Does this issue still exists in 8 LTS?

Actions #5

Updated by Alexander Opitz almost 6 years ago

  • Status changed from Needs Feedback to Closed

No feedback within the last 90 days => closing this issue.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions #6

Updated by Franz Holzinger almost 6 years ago

  • TYPO3 Version changed from 7 to 8

This bug is not present in TYPO3 8.7.15

I have had another misconfiguration. Now I reedit it.

Test-case:

Add a header image on the live workspace and add a different header image on a "entwurf" workspace. Do this on a preview page.
Then the header image on the live workspace has shown duplicate images: the header image of the live workspace and also all header images of another other workspace.

This is fixed in TYPO3 8.7.15.

Actions

Also available in: Atom PDF