Bug #79314
closedOutdated PHPDoc comment in AbstractTreeView
100%
Description
While making an old extension work in TYPO3 7.6 and 8, I found that behavior of the AbstractTreeView has changed between 7.6.
The description of the variable $makeHTML is outdated, as it describes a configuration option no longer existing:
/** * If TRUE, HTML code is also accumulated in ->tree array during rendering of the tree. * If 2, then also the icon prefix code (depthData) is stored * * @var int */ public $makeHTML = 1;
The variable is treated as a boolean since 7.6, the mentioned value of "2" does not have any effect, so the affected line should be removed.
Ideally, the variable should be converted to a boolean. But as it's a public variable, I assume this would be considered a breaking change, so please let me know if I should provide a patch set for that, too.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51308
Updated by Gerrit Code Review almost 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51308
Updated by Stefan Rotsch almost 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1c09924f1b5eacfee6564c436d88070bc94a45ec.