Bug #79568

baseURL determination of EXT:rtehtmlarea fails in frontend editing

Added by Pierrick Caillon over 2 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2017-01-31
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
rte feedit
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

The htmlarea RTE fails to correctly determine the baseURI to define in the editing iframe when a slash is present unencoded in the url parameters.
The case happens with frontend editing. When editing an existing record. An unencoded return url is added to the edit frame parameters. In backend the URL is already properly encoded when present, for example, when searching a record with the global search box and clicking on the record.

Occurs with Mozilla Firefox 51. Does not occur with Google Chrome. Not Verified with Internet Explorer.

Reproduction steps:
  1. Set up frontend editing (https://wiki.typo3.org/Frontend_editing and Content Elements (fluid_styled_content) template included for editpanel)
  2. Create or choose a Text & Image or Text & Media or any other content with a Rich Text Editor
  3. Put a table with default settings in the RTE, it will make the fix visible without inspection
  4. Go to the page in frontend and click the edit icon of the created or chosen content
  5. In the edit popup, the URL ends with &returnUrl=sysext/backend/Resources/Private/Templates/Close.html
  6. In the RTE, table borders are not visible despite activating the show table borders button

79568-firefox.jpg View - RTE result in Firefox (93.6 KB) Pierrick Caillon, 2017-01-31 12:54

79568-chrome.jpg View - RTE result in Chrome (84.8 KB) Pierrick Caillon, 2017-01-31 12:54

RTE 79568 7.6 6.2.patch View - Patch for 7.6 and 6.2 (2.09 KB) Pierrick Caillon, 2017-01-31 14:23


Related issues

Related to TYPO3 Core - Bug #65705: baseURL determination of EXT:rtehtmlare fails in edge case Closed 2015-03-12
Related to TYPO3 Core - Bug #65608: BaseURL is wrong in Frontend when using RealURL with config.absRefPrefix Closed 2015-03-09

Associated revisions

Revision a8c6b34b (diff)
Added by Pierrick Caillon over 2 years ago

[BUGFIX] Wrong computed baseURL with FE editing RTE

Frontend editing button for editing a content now
url encode the return URL. The HTMLAREA baseURL
computation now excludes query parameters and anchor
from the document URL.

Resolves: #79568
Related: #65705
Related: #65608
Releases: master
Change-Id: I57ae5257ab62cff1398a0b2d088fe7ba3b126c76
Reviewed-on: https://review.typo3.org/51489
Tested-by: TYPO3com <>
Reviewed-by: Mona Muzaffar <>
Tested-by: Mona Muzaffar <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 5df7e2c9 (diff)
Added by Jigal van Hemert over 2 years ago

[BUGFIX] Wrong computed baseURL with FE editing RTE

Frontend editing button for editing a content now
url encode the return URL. The HTMLAREA baseURL
computation now excludes query parameters and anchor
from the document URL.

Resolves: #79568
Related: #65705
Related: #65608
Releases: 7.6
Change-Id: I57ae5257ab62cff1398a0b2d088fe7ba3b126c76
Reviewed-on: https://review.typo3.org/52142
Tested-by: TYPO3com <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Elmar Hinz <>
Tested-by: Riccardo De Contardi <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Pierrick Caillon over 2 years ago

  • Description updated (diff)

#2 Updated by Pierrick Caillon over 2 years ago

Added screenshots.

#3 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51489

#4 Updated by Pierrick Caillon over 2 years ago

You can find the patch for current LTS releases attached.

#5 Updated by Pierrick Caillon over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52142

#7 Updated by Jigal van Hemert over 2 years ago

  • Status changed from Under Review to Resolved

#8 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF