Project

General

Profile

Actions

Bug #79686

closed

Found PHP Runtime notices in core: Only variables should be passed by reference

Added by Armin Vieweg almost 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-02-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

In latest 7.6:

Core: Error handler (BE): PHP Runtime Notice: Only variables should be passed by reference in C:\...\vendor\typo3\cms\typo3\sysext\backend\Classes\Form\Container\FlexFormNoTabsContainer.php line 45

In current master, it's line 44.

The problem is the combination of array_keys inside of array_pop:

$sheetName = array_pop(array_keys($flexFormDataStructureArray['sheets']));

I had a similar issue in my DCE extension. Here I've used a nested reset which caused the same issue:

$datamap = reset(reset($pObj->datamap));

So this affects all array commands, which handles given array parameter as reference.

Actions #1

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51590

Actions #2

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51694

Actions #3

Updated by Andreas Fernandez almost 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF