Bug #79686
closedFound PHP Runtime notices in core: Only variables should be passed by reference
100%
Description
In latest 7.6:
Core: Error handler (BE): PHP Runtime Notice: Only variables should be passed by reference in C:\...\vendor\typo3\cms\typo3\sysext\backend\Classes\Form\Container\FlexFormNoTabsContainer.php line 45
In current master, it's line 44.
The problem is the combination of array_keys inside of array_pop:
$sheetName = array_pop(array_keys($flexFormDataStructureArray['sheets']));
I had a similar issue in my DCE extension. Here I've used a nested reset which caused the same issue:
$datamap = reset(reset($pObj->datamap));
So this affects all array commands, which handles given array parameter as reference.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51590
Updated by Gerrit Code Review almost 8 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51694
Updated by Andreas Fernandez almost 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5fea714da171261aa48d144f2dd978f09f55267d.