Project

General

Profile

Actions

Bug #79718

closed

Install tool UX: do not remove db analyzer fields before upgrade wizards were run

Added by Christian Kuhn almost 8 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2017-02-09
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

With the latest big fsc / csc changes, it is important during upgrade to run run the "section_frame" and "menu_type" upgrade wizards before those fields are deleted from DB.

When upgrading, this happens currently:
  • db schema analyzer from "important actions" currently proposes to rename / delete these fields.
  • the first upgrade wizard proposes to only add new fields, but to not delete those fields directly.

This still gives the problem that people execute the schema analyzer "do whatever it wants here", and after that only execute the upgrade wizards. In this case, those wizards are not able to migrate anymore.

Maybe, it would be a good idea to at least show a warning in the schema analyzer "did you just ugrade? if so, check the upgrade wizards before renaming / removing fields" in the schema analyzer section of important actions to hint admins about this issue?

Actions #1

Updated by Thomas Hohn over 7 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Stephan Großberndt over 7 years ago

The order in the upgrade wizard is always:

1. create new fields
2. run upgrade wizards which may edit fields themself
3. edit all remaining fields which were not handled by an upgrade wizard
(4. remove no longer used field)

Using the "db schema analyzer" if the upgrade wizards are not run yet may indeed create havoc.

Actions #3

Updated by Gerrit Code Review over 7 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51833

Actions #4

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51833

Actions #5

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51833

Actions #6

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51833

Actions #7

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51833

Actions #8

Updated by Benni Mack over 7 years ago

  • Target version changed from 8 LTS to next-patchlevel
Actions #9

Updated by Riccardo De Contardi about 7 years ago

  • Category set to Install Tool
Actions #10

Updated by Christian Kuhn about 6 years ago

  • Status changed from Under Review to Rejected

patch has been abandoned. i think there is currently not much we could do.

Actions #11

Updated by Stephan Großberndt about 6 years ago

  • Status changed from Rejected to New
  • Target version deleted (next-patchlevel)
  • TYPO3 Version changed from 8 to 9

There is: Display a warning in DB Schema Analzyer if there are upgrade wizards that need to be run.

Actions #12

Updated by Christian Kuhn about 1 year ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF