Task #79720
closedRemove ses_name from tables fe_sessions and be_sessions
100%
Description
Both fe_session and be_session table currently have a combined primary key on ses_id / ses_name.
with the new session framework, ->get() should be only called using the ses_id part of the primary key, so it is probably easy (needs verify) to remove ses_name from primary key.
Apart from that, we should check why setting ses_name (along with the typo3-conf-vars global) is a necessary setting anyway, and if we maybe could hard-code that to the default strings and disallow overwriting the session cookie name altogether?
Even if ses_name is kept for whatever reason, the primary key should have a reconsideration.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821
Updated by Gerrit Code Review almost 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821
Updated by Thomas Hohn almost 8 years ago
- Subject changed from Kick ses_name or at least remove it from primary key to Remove ses_name from tables fe_sessions and be_sessions
Updated by Gerrit Code Review almost 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821
Updated by Gerrit Code Review almost 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821
Updated by Gerrit Code Review almost 8 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821
Updated by Gerrit Code Review almost 8 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821
Updated by Gerrit Code Review almost 8 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821
Updated by Gerrit Code Review almost 8 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821
Updated by Gerrit Code Review almost 8 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821
Updated by Gerrit Code Review almost 8 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821
Updated by Gerrit Code Review almost 8 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821
Updated by Thomas Hohn almost 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c3c7c401a342d3436845d197ce1848688e4f96c2.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed