Project

General

Profile

Actions

Task #79720

closed

Remove ses_name from tables fe_sessions and be_sessions

Added by Christian Kuhn about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2017-02-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:
Stabilization Sprint

Description

Both fe_session and be_session table currently have a combined primary key on ses_id / ses_name.

with the new session framework, ->get() should be only called using the ses_id part of the primary key, so it is probably easy (needs verify) to remove ses_name from primary key.

Apart from that, we should check why setting ses_name (along with the typo3-conf-vars global) is a necessary setting anyway, and if we maybe could hard-code that to the default strings and disallow overwriting the session cookie name altogether?

Even if ses_name is kept for whatever reason, the primary key should have a reconsideration.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Feature #70316: Introduce Session FrameworkClosedMathias Schreiber2015-10-02

Actions
Related to TYPO3 Core - Bug #79628: Long primary index on be_session and fe_session tableClosed2017-02-04

Actions
Actions #1

Updated by Gerrit Code Review about 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821

Actions #2

Updated by Gerrit Code Review about 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821

Actions #3

Updated by Thomas Hohn about 7 years ago

  • Subject changed from Kick ses_name or at least remove it from primary key to Remove ses_name from tables fe_sessions and be_sessions
Actions #4

Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821

Actions #5

Updated by Gerrit Code Review about 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821

Actions #6

Updated by Gerrit Code Review about 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821

Actions #7

Updated by Gerrit Code Review about 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821

Actions #8

Updated by Gerrit Code Review about 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821

Actions #9

Updated by Gerrit Code Review about 7 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821

Actions #10

Updated by Gerrit Code Review about 7 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821

Actions #11

Updated by Gerrit Code Review about 7 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821

Actions #12

Updated by Gerrit Code Review about 7 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51821

Actions #13

Updated by Thomas Hohn about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #14

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF