Task #80027

Remove TCA config 'max' on inputDateTime fields

Added by Christian Kuhn over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2017-02-26
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:
Stabilization Sprint

Description

It would be a good idea to remove the 'max' config option in TcaMigration class automatically
for all renderType="inputDateTime" fields.

We've had a max=20 in core for pages.newUntil field for a while, and
this killed the db entry on storing.

Since that is a relatively hard to spot and test issue for extension
authors during upgrade, it might be the easiest solution to just have
a TcaMigration (with unit test) to remove 'max' on those fields
automatically.


Related issues

Related to TYPO3 Core - Bug #80022: DateTime parse error on edit pages field newUntil Closed 2017-02-25

Associated revisions

Revision 184716b6 (diff)
Added by Thomas Hohn over 2 years ago

[TASK] Remove TCA config 'max' on inputDateTime fields

The TCA migration removes the 'max' config option for
renderType="inputDateTime" since this should not be set
for this renderType to avoid performance issues when
storing data in the DB.

Resolves: #80027
Releases: master
Change-Id: Ia8d6d95e0830c6173522757ece5e3f48db618f33
Reviewed-on: https://review.typo3.org/51903
Reviewed-by: Christer V <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>
Reviewed-by: Frank Nägler <>
Tested-by: Frank Nägler <>

History

#1 Updated by Christian Kuhn over 2 years ago

  • Description updated (diff)

#2 Updated by Thomas Hohn over 2 years ago

  • Assignee set to Thomas Hohn

#3 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51903

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51903

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51903

#6 Updated by Thomas Hohn over 2 years ago

  • Description updated (diff)

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51903

#8 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51903

#9 Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51903

#10 Updated by Thomas Hohn over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF