Bug #80609

imagecaption_position is used by css_styled_content and must be in Core!

Added by Leonie Philine Bitto over 1 year ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
-
Start date:
2017-03-31
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
css_styled_content, textpic, captionAlign, tt_content, imagecaption_position
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

Hi!

It is stated in:
typo3_src (7.6 LTS)/typo3/sysext/core/Documentation/Changelog/7.2/Breaking-65922-MoveUnusedTt_contentTcaFieldsToCompatibility6.rst

that:

There are some database fields defined in 'frontend' which are not used by `frontend` or `css_styled_content`. These fields have been moved to `compatibility6`.

- altText
- imagecaption
- imagecaption_position
- image_link
- longdescURL
- titleText

This is wrong. At least imagecaption_position - possibly also other fields, but that I did not test - are indeed used by css_styled_content!
Therefore, this field must be migrated back into the core. To use current functionality (as captionAlign), it is madness to use a compatibility extension.

See also: \TYPO3\CMS\CssStyledContent\Controller\CssStyledContentController::render_textpic() , Ctrl+F for 'captionAlign', and
(7.6 LTS) typo3_src/typo3/sysext/css_styled_content/static/setup.txt:795

imagecaption_position is also used as css_styled_content imageblock palette in: typo3_src/typo3/sysext/css_styled_content/Configuration/TCA/Overrides/tt_content.php:431

Associated revisions

Revision 6d258d97 (diff)
Added by Nicole Cordes over 1 year ago

[BUGFIX] Readd used fields in css_styled_content

These fields were removed from EXT:frontend and moved to compatibility6.
But both fields are still used by csc and should be provided by the
extension itself.

Resolves: #80609
Releases: 7.6
Change-Id: I07db632ab851dac94749924dd3d2fbadd8016802
Reviewed-on: https://review.typo3.org/53666
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Leonie Philine Bitto over 1 year ago

To make the issue clearer:

The field(s) has/have been moved from EXT:frontend into EXT:compatibility6 - even though imagecaption_position is an active TYPO3 7 feature of css_styled_content.

This means that while imagecaption_position might be misplaced in EXT:frontend, it must now be moved into EXT:css_styled_content - and definitely not into EXT:compatibility6.

#2 Updated by Leonie Philine Bitto over 1 year ago

  • Category set to Content Rendering
  • Tags set to css_styled_content, textpic, captionAlign, tt_content, imagecaption_position
  • Complexity set to easy
  • Is Regression changed from No to Yes

#3 Updated by David Bruchmann over 1 year ago

I can confirm that issue, the fields should be moved to css_styled_content.
"compatibility6" seems being the wrong place too for me as long as the fields are (still) used by css_styled_content.

Probably it's not "madness" but just has been a task by people who primary use fluid_styled_content now without much care about the good old css_styled_content ;-)

#4 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53666

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53666

#6 Updated by Nicole Cordes over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF