Task #81143

Some Fluid ViewHelpers are still not converted to static calling

Added by Claus Due about 2 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-05-05
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Compiled templates can be further improved by doing so.

Associated revisions

Revision 3eebf358 (diff)
Added by Claus Due about 2 years ago

[TASK] Convert ViewHelpers to static calling

Several ViewHelpers were not yet converted to use
the renderStatic method and CompileWith* traits
from Fluid. This patch converts those.

Change-Id: I17773d4014969c5ad5a3b87bffd34c14871a2958
Releases: master
Resolves: #81143
Reviewed-on: https://review.typo3.org/52707
Tested-by: TYPO3com <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision ef16c8ab (diff)
Added by Claus Due about 2 years ago

[FOLLOWUP][BUGFIX] Convert ViewHelpers to static calling

Followup to prevent a variable reassignment which in
turn prevents overriding the controller, extension and
plugin name in f:uri.action.

Change-Id: I766e110555e03b36b93c777c63bbd629a42999fd
Resolves: #81143
Releases: master
Reviewed-on: https://review.typo3.org/52778
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision a819b117 (diff)
Added by Claus Due about 2 years ago

[TASK] Convert ViewHelpers to static calling

Several ViewHelpers were not yet converted to use
the renderStatic method and CompileWith* traits
from Fluid. This patch converts those.

Change-Id: I17773d4014969c5ad5a3b87bffd34c14871a2958
Releases: 8.7,master
Resolves: #81143
Reviewed-on: https://review.typo3.org/52775
Tested-by: TYPO3com <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52707

#2 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52707

#3 Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52707

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52775

#5 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52775

#6 Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52778

#8 Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved

#9 Updated by Kasper Ligaard about 2 years ago

Out of interest: Will it help compiled templates in-and-of-itself or will other changes be needed elsewhere afterwards? Basically I guess I am asking: How can compiled templates be "further improved" by this change?

#10 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF