Project

General

Profile

Actions

Bug #81267

closed

Error Handler fails if redirect domain is not absolute

Added by Anja Leichsenring over 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-05-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

[FE][pageNotFound_handling] set to /index.php?id=200 (that is the designated 404 page). This is necessary for a multilanguage setup with several domain records.

With the change http://forge.typo3.org/issues/81031 a strict type comparison is introduced in the error handling process, that now skips the host determination, if none is given. For my case, the host part is obviously not only empty, but not even present. The new strict check skips the host determination, so we stick to a relative URL. This is then redirected some lines down, resulting in the markup of that page being part of the URL.

Description is pretty difficult, sorry :/.
A simple isEmpty check instead of the strict type empty string one, solves the problem.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #81031: Code and comment clean upClosedBenni Mack2017-04-27

Actions
Actions #1

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52859

Actions #2

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52859

Actions #3

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52859

Actions #4

Updated by Anja Leichsenring over 7 years ago

  • Related to Task #81031: Code and comment clean up added
Actions #5

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52859

Actions #6

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52862

Actions #7

Updated by Anonymous over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF