Bug #81345

BE page module => 'Make new translation of this page' doesn't use command localize to create translation

Added by Frans Saris over 2 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Localization
Target version:
-
Start date:
2017-05-26
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The BE page module option 'Make new translation of this page' doesn't use command localize to create a translation of the page but only shows the form of an empty pages_language_overlay page. Due to this the existing page titles don't get the [Translate to...] .. prefixes etc.


Related issues

Related to TYPO3 Core - Bug #87328: "Make new translation of this page" can create invalid page translations New 2019-01-04

Associated revisions

Revision 594d694e (diff)
Added by Frans Saris almost 2 years ago

[BUGFIX] Use localize command when translating page record

Currently, when using the dropdown to create a page translation within
the Page Module, DataHandler is called with just a simple "new" record
of type "pages_language_overlay".

However, a classic "localize" DataHandler command is more appropriate,
allowing to utilize several localization functionalities built in.

In order to achieve this, the option tags in the selector contain the full
URL to the DataHandler call, as well as the redirect to FormEngine (which
in turn redirects back to the current page module URL).

Resolves: #81345
Releases: master, 8.7
Change-Id: I740c2d1d11494963283bc14b1f534bd344d0764a
Reviewed-on: https://review.typo3.org/52945
Reviewed-by: Wouter Wolters <>
Tested-by: TYPO3com <>
Tested-by: Wouter Wolters <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision 030cfb29 (diff)
Added by Frans Saris almost 2 years ago

[BUGFIX] Use localize command when translating page record

Currently, when using the dropdown to create a page translation within
the Page Module, DataHandler is called with just a simple "new" record
of type "pages_language_overlay".

However, a classic "localize" DataHandler command is more appropriate,
allowing to utilize several localization functionalities built in.

In order to achieve this, the option tags in the selector contain the full
URL to the DataHandler call, as well as the redirect to FormEngine (which
in turn redirects back to the current page module URL).

Resolves: #81345
Releases: master, 8.7
Change-Id: I740c2d1d11494963283bc14b1f534bd344d0764a
Reviewed-on: https://review.typo3.org/54220
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52945

#2 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52945

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52945

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52945

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52945

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54220

#7 Updated by Frans Saris almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

#9 Updated by Mathias Brodala 8 months ago

  • Related to Bug #87328: "Make new translation of this page" can create invalid page translations added

Also available in: Atom PDF