Bug #81622

Wrong comment for sys_language_contentOL

Added by Tymoteusz Motylewski 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-06-19
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:
On Location Sprint

Description

The comment in TSFE for sys_language_contentOL should be fixed
is:

    /**
     * Site content overlay flag; If set - and sys_language_content is > 0 - ,
     * records selected will try to look for a translation pointing to their uid. (If
     * configured in [ctrl][languageField] / [ctrl][transOrigP...]
     * @var int
     */
    public $sys_language_contentOL = 0;

should be:

    /**
     * Site content overlay flag; If set - and sys_language_content is > 0 - ,
     * records selected will try to look for a translation pointing to their uid. (If
     * configured in [ctrl][languageField] / [ctrl][transOrigP...]
     * Possible values: [0,1,hideNonTranslated]
     * This flag is set based on TypoScript config.sys_language_overlay setting
     * 
     * @var int|string
     */
    public $sys_language_contentOL = 0;

Associated revisions

Revision 86166840 (diff)
Added by Ruslan Steiger 3 months ago

[TASK] Optimize comment for sys_language_contentOL

Resolves: #81622
Releases: master, 8.7
Change-Id: Ibe6097846cd7945ef5dc9808d936346591fa1d56
Reviewed-on: https://review.typo3.org/53493
Reviewed-by: Susanne Moog <>
Tested-by: TYPO3com <>
Reviewed-by: Marc Wöhlken <>
Tested-by: Marc Wöhlken <>
Reviewed-by: Daniel Maier <>
Tested-by: Daniel Maier <>
Reviewed-by: Philipp Gampe <>
Tested-by: Philipp Gampe <>
Reviewed-by: Joerg Boesche <>
Tested-by: Joerg Boesche <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

Revision 9e8f8cab (diff)
Added by Ruslan Steiger 3 months ago

[TASK] Optimize comment for sys_language_contentOL

Resolves: #81622
Releases: master, 8.7
Change-Id: Ibe6097846cd7945ef5dc9808d936346591fa1d56
Reviewed-on: https://review.typo3.org/53527
Tested-by: TYPO3com <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Tymoteusz Motylewski 4 months ago

  • Complexity set to no-brainer

#2 Updated by Susanne Moog 3 months ago

  • Sprint Focus set to On Location Sprint

#3 Updated by Tymoteusz Motylewski 3 months ago

Or even better, the comment should be based on the recently updated documentation:
https://docs.typo3.org/typo3cms/TyposcriptReference/Setup/Config/Index.html?highlight=sys_language_contentol#sys-language-overlay

I see right now that my proposal from the ticket is not clear enough.

#4 Updated by Gerrit Code Review 3 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53493

#5 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53493

#6 Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53527

#7 Updated by Ruslan Steiger 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF