Bug #81749

f:link.action renders invalid links if pageUid param is omitted

Added by Andreas Fernandez about 4 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Fluid
Target version:
Start date:
2017-06-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Due to #81213, the pageUid parameter in f:link.action is now always casted to an int. This leads to unwanted behaviour, as pageUid is 0 in such case, causing to break UriBuilder->uriFor() as the pageUid is checked for null. As null !== 0, the page uid is not determined correctly, causing typolink_URL to render empty strings.

This may be tested with EXT:indexed_search, the "Advanced search" link is broken and always links to the current page.
Side effect: submitting its form and clicking "Advanced search" then, exceptions occur.


Related issues

Related to TYPO3 Core - Task #81213: Deprecate ViewHelper render() argument supportClosed2017-05-12

Actions
#1

Updated by Andreas Fernandez about 4 years ago

  • Related to Task #81213: Deprecate ViewHelper render() argument support added
#2

Updated by Andreas Fernandez about 4 years ago

  • Description updated (diff)
#3

Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53359

#4

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53359

#5

Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53359

#6

Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53359

#7

Updated by Andreas Fernandez about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#8

Updated by Benni Mack almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF