Task #81213

Deprecate ViewHelper render() argument support

Added by Claus Due over 2 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-05-12
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

To bring the CMS Fluid integrations closer to vanilla Fluid implementations we need to deprecate support for render method arguments.


Related issues

Related to TYPO3 Core - Bug #81749: f:link.action renders invalid links if pageUid param is omitted Closed 2017-06-29

Associated revisions

Revision 3848b738 (diff)
Added by Claus Due over 2 years ago

[TASK] Deprecate render method arguments on ViewHelpers

Deprecates usage of arguments on render methods and
refactors the abstract ViewHelper class to avoid injecting
ReflectionService in every ViewHelper, calling on it only
when the ViewHelper actually requires it.

Safe removal since the DI property is declared private and
thus cannot be accessed in ViewHelper classes.

Change-Id: I94bb7e9f306b34c25dc31519eb17316c88ea0540
Resolves: #81213
Releases: master
Reviewed-on: https://review.typo3.org/52796
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision a2bef2a1 (diff)
Added by Claus Due over 2 years ago

[FOLLOWUP][TASK] Deprecate render method arguments on ViewHelpers

Followup patch to migrate f:widget.autocomplete which
had been missed by the previous patch.

Change-Id: I9e2552925df84f225144b1120a93bf65d9874047
Resolves: #81213
Releases: master
Reviewed-on: https://review.typo3.org/53199
Reviewed-by: Georg Ringer <>
Tested-by: TYPO3com <>
Reviewed-by: Simon Schaufelberger <>
Tested-by: Simon Schaufelberger <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 36696a35 (diff)
Added by Andreas Fernandez about 2 years ago

[BUGFIX] Do no force int cast of pageUid in f:link.action

Since #81213, the `pageUid` argument is cast to an int. If that
parameter is omitted, pageUid becomes 0. UriBuilder is able to
determine the page uid by itself, but for this, $pageUid must be
null.

Resolves: #81749
Related: #81213
Releases: master
Change-Id: I030ef28efb1a3fdd14246f84c8ce8c464ba04a4d
Reviewed-on: https://review.typo3.org/53359
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Claus Due <>
Reviewed-by: Joerg Boesche <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52796

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52796

#3 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52796

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52796

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52796

#6 Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52796

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52796

#8 Updated by Anonymous over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53199

#10 Updated by Anonymous over 2 years ago

  • Status changed from Under Review to Resolved

#11 Updated by Andreas Fernandez about 2 years ago

  • Related to Bug #81749: f:link.action renders invalid links if pageUid param is omitted added

#12 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF