Bug #81810

"," not possible in regex of config.linkVars

Added by Sascha Egerer over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2017-07-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:
On Location Sprint

Description

The TypoScript setting config.linkVars contains Link parameters with a regex of possible values. The parameters are seperated by a ,.
The implementation does explode the string by , to get an array of paramters and there values.
But this fails if the regex does containe a , character and ends up in broken params and values.

e.g. config.linkVars = country(/^[a-z]{2,3}$/),L(0-12) is not possible as the string is also exploded at {2,3}.
Instead of
country(/^[a-z]{2,3}$/)
L(0-12)
the string is exploded to
country(/^[a-z]{2
3}$/)
L(0-12)

#1

Updated by Sascha Egerer over 3 years ago

  • Description updated (diff)
#2

Updated by Georg Ringer over 3 years ago

any idea how this could be avoided without having a new syntax?

#3

Updated by Sascha Egerer over 3 years ago

Georg Ringer wrote:

any idea how this could be avoided without having a new syntax?

The "regex" or value is always surrounded by (), right? So we need to explode it with a regular expression that , inside of () are no split values.

#4

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53478

#5

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53478

#6

Updated by Sascha Egerer over 3 years ago

  • Sprint Focus changed from Remote Sprint to On Location Sprint
#7

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53478

#8

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53507

#9

Updated by Sascha Egerer over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#10

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF