Bug #82053
closedonlyAllowedTables is wrongly evaluated while changing doktype on page language overlay
100%
Description
When I change the doktype of a pages_language_overlay
to a doktype which has onlyAllowedTables
set, the call DataHandler::doesPageHaveUnallowedTables
is done with the id of the pages_language_overlay
entry, instead of with the real page uid which needs to be checked.
The affected part:
public function checkValue($table, $field, $value, $id, $status, $realPid, $tscPID)
{
// Result array
$res = [];
// Processing special case of field pages.doktype
if (($table === 'pages' || $table === 'pages_language_overlay') && $field === 'doktype') {
// ...
if ($status === 'update') {
// This checks 1) if we should check for disallowed tables and 2) if there are records from disallowed tables on the current page
$onlyAllowedTables = isset($GLOBALS['PAGES_TYPES'][$value]['onlyAllowedTables']) ? $GLOBALS['PAGES_TYPES'][$value]['onlyAllowedTables'] : $GLOBALS['PAGES_TYPES']['default']['onlyAllowedTables'];
if ($onlyAllowedTables) {
// this is always called with the $id of the record, whether it is a pages or pages_language_overlay entry
$theWrongTables = $this->doesPageHaveUnallowedTables($id, $value);
if ($theWrongTables) {
// ...
return $res;
}
}
}
}
// ...
}
Possible solution: Use $realPid
if the record is pages_language_overlay
or use $id
if the record is pages
Updated by Gerrit Code Review over 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53687
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53687
Updated by Gerrit Code Review about 7 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54672
Updated by Oliver Hader over 6 years ago
- Assignee deleted (
Wolfgang Klinger) - Target version deleted (
next-patchlevel)
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53687
Updated by Gerrit Code Review over 6 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53687
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54672
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54672
Updated by Wolfgang Klinger over 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset cbda51a703ce968cb9210430b03feaad4c43a4b3.