Bug #82056

Missing Back Button in DatabaseRecordList (module web_list) despite valid returnUrl

Added by Georg Tiefenbrunn 4 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2017-08-08
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In TYPO3 CMS 7.6 and up a back button should be rendered (in the left doc header button section) of the list module if url parameter returnUrl is set.

Function DatabaseRecordList->getDocHeaderButtons() uses TYPO3\CMS\Backend\Template\Components\ButtonBar to register buttons. it looks like as the back button was forgotten in https://github.com/TYPO3/TYPO3.CMS/commit/79cf7c711e9dea52e39eaa28dd9fde68f10e23c7#diff-42cfb88bd58fd064d043722f827b1cc5.

            // Back
            if ($this->returnUrl) {
                $href = htmlspecialchars(GeneralUtility::linkThisUrl($this->returnUrl, ['id' => $this->id]));
                $buttons['back'] = '<a href="' . $href . '" class="typo3-goBack" title="'
                    . $lang->sL('LLL:EXT:lang/locallang_core.xlf:labels.goBack', true) . '">'
                    . $this->iconFactory->getIcon('actions-view-go-back', Icon::SIZE_SMALL) . '</a>';
            }

... should be replaced with something like ...

            // Back
            if ($this->returnUrl) {
                $backButton = $buttonBar->makeLinkButton()
                    ->setHref($this->returnUrl)
                    ->setTitle($lang->sL('LLL:EXT:lang/locallang_core.xlf:labels.goBack'))
                    ->setIcon($this->iconFactory->getIcon('actions-view-go-back', Icon::SIZE_SMALL));
                $buttonBar->addButton($backButton, ButtonBar::BUTTON_POSITION_LEFT);
            }

Associated revisions

Revision f65b811e (diff)
Added by Wouter Wolters about 1 month ago

[BUGFIX] Replace forgotten back button to new button API

With #69884 the new button API was introduced but the back button
in DatabaseRecordList was forgotten. The button is now done with
the new API.

Resolves: #82056
Releases: master
Change-Id: Icc6480af3a1b4a04e7222dc92cdb58bf9549007d
Reviewed-on: https://review.typo3.org/53722
Tested-by: TYPO3com <>
Reviewed-by: Georg Tiefenbrunn <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Tested-by: Georg Tiefenbrunn <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision 3ace4185 (diff)
Added by Wouter Wolters about 1 month ago

[BUGFIX] Replace forgotten back button to new button API

With #69884 the new button API was introduced but the back button
in DatabaseRecordList was forgotten. The button is now done with
the new API.

Resolves: #82056
Releases: master,8.7
Change-Id: Icc6480af3a1b4a04e7222dc92cdb58bf9549007d
Reviewed-on: https://review.typo3.org/54564
Tested-by: TYPO3com <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53722

#2 Updated by Wouter Wolters about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Gerrit Code Review about 1 month ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54564

#4 Updated by Wouter Wolters about 1 month ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF