Project

General

Profile

Actions

Bug #82101

closed

Change ClickEnlargeViewHelper image argument type

Added by Kevin Ditscheid over 6 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
Fluid Styled Content
Target version:
-
Start date:
2017-08-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I found that the image argument of the ClickEnlargeViewHelper has to be of type FileReference. This crashed my CE, because I tried to add a File object as the image to render for click enlarge. Out of curiosity, I changed the type of the image argument to accept FileInterface and it worked perfectly for me.
Is there a reason why this argument is limited to FileReferences only or can it be changed to accept FileInterface?
As far as I see, the FileReference is just another implementation of the FileInterface, so this shouldn't lead to any issues in the code later on, unless something is relying on the image to be a FileReference, which would be an error then imo.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #73814: Make ClickEnlargeViewHelper output data againClosedWouter Wolters2016-03-01

Actions
Actions #1

Updated by Wouter Wolters over 6 years ago

  • Assignee deleted (Benni Mack)
Actions #2

Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60435

Actions #3

Updated by Benni Mack about 5 years ago

  • Related to Bug #73814: Make ClickEnlargeViewHelper output data again added
Actions #4

Updated by Gerrit Code Review about 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60444

Actions #5

Updated by Benni Mack about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF