Bug #82101
closedChange ClickEnlargeViewHelper image argument type
100%
Description
I found that the image argument of the ClickEnlargeViewHelper has to be of type FileReference. This crashed my CE, because I tried to add a File object as the image to render for click enlarge. Out of curiosity, I changed the type of the image argument to accept FileInterface and it worked perfectly for me.
Is there a reason why this argument is limited to FileReferences only or can it be changed to accept FileInterface?
As far as I see, the FileReference is just another implementation of the FileInterface, so this shouldn't lead to any issues in the code later on, unless something is relying on the image to be a FileReference, which would be an error then imo.
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60435
Updated by Benni Mack over 5 years ago
- Related to Bug #73814: Make ClickEnlargeViewHelper output data again added
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60444
Updated by Benni Mack over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5894cbb48f5cf121ed20023469951ef9f93621c5.