Project

General

Profile

Actions
Copy link

Task #82237

closed

Backend generates the same URL multiple times, caching can help performance

Added by Claus Due about 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-08-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:
On Location Sprint

Description

The TYPO3 backend is very eager to generate the same URL multiple times. This isn't necessarily a problem in itself but the UriBuilder both continuously re-loads backend routes and uses a class which takes a constructor argument and immediately parses the provided URL. Those things combined result in several hundred calls to GeneralUtility::makeInstance and about three times as many calls to explode().

Caching (in memory only) a generated URL based on route name, parameters and abs/rel type saves about 2/3 of calls to generate route URLs in the page module alone. Turning the UriBuilder into a singleton further facilitates this and reduces calls to instanciateObject.

Actions
Copy link
 #1

Updated by Gerrit Code Review about 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53827

Actions
Copy link
 #2

Updated by Gerrit Code Review about 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53827

Actions
Copy link
 #3

Updated by Gerrit Code Review almost 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53827

Actions
Copy link
 #4

Updated by Gerrit Code Review almost 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53827

Actions
Copy link
 #5

Updated by Gerrit Code Review almost 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53827

Actions
Copy link
 #6

Updated by Gerrit Code Review almost 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53827

Actions
Copy link
 #7

Updated by Susanne Moog about 6 years ago

  • Sprint Focus set to On Location Sprint
Actions
Copy link
 #8

Updated by Gerrit Code Review about 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53827

Actions
Copy link
 #9

Updated by Gerrit Code Review about 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53827

Actions
Copy link
 #10

Updated by Gerrit Code Review about 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53827

Actions
Copy link
 #11

Updated by Anonymous about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #12

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF