Project

General

Profile

Actions

Bug #82460

closed

Exception in FE if admPanel is enabled and values are overridden

Added by Markus Klein over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Frontend
Target version:
Start date:
2017-09-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

situation

Using this user TSconfig

admPanel {
  enable {
    preview = 1
  }
  override {
    preview = 1
    preview.showHiddenRecords = 1
  }
}

result

yields this error in FE

#1462820645: accessTimeStamp needs to be set to an integer value, but is empty! Maybe $GLOBALS[‘SIM_ACCESS_TIME’] has been overridden somewhere? 

expected

The expected behaviour would be to see hidden records and the red "preview" symbol at the top right.

solution

The frontend request handling initializes the admin panel, which evaluates the configuration.
Part of this evaluation is to set $GLOBALS[‘SIM_ACCESS_TIME’] to the value given as "simulate time" in the admin panel (or via configuration). This fails and hence the value gets zero, which leads to the seen exception.

The evaluation fails as it calls $simTime = $backendUser->adminPanel->extGetFeAdminValue('preview', 'simulateDate');.
As seen in the configuration above the value for "simluateDate" is not configured and the logic inside extGetFeAdminValue returns the value of 'preview' in this case, which hasn't been requested.

The fix is to make sure that this lookup on the first key ('preview') is never done if a subkey ('simulateDate') is requested.

Actions #1

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54112

Actions #2

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54123

Actions #3

Updated by Markus Klein over 6 years ago

  • Description updated (diff)
Actions #4

Updated by Alex Kellner over 6 years ago

The same here in TYPO3 8.7.6

Quick workarround - add a simulateDate:

admPanel.override.preview.simulateDate = 123456798

Or dynamically via ext_localconf.php:

$setSimulateDateString = 'admPanel.override.preview.simulateDate = ' . time();
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addUserTSConfig($setSimulateDateString);

Actions #5

Updated by Markus Klein over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54198

Actions #7

Updated by Markus Klein over 6 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54198

Actions #9

Updated by Stephan Großberndt almost 6 years ago

  • Status changed from Under Review to Resolved
Actions #10

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF