Bug #82518

Broken composite form element check in RenderAllFormValuesViewHelper

Added by Mathias Brodala about 1 year ago. Updated about 2 months ago.

Status:
Closed
Priority:
Must have
Category:
-
Target version:
Start date:
2017-09-20
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

The check for composite form elements in the RenderAllFormValuesViewHelper is broken:

            if (
                !$element instanceof FormElementInterface
                || $element->getType() === 'Honeypot'
                || (
                    isset($renderingOptions['_isCompositeFormElement'])
                    && $renderingOptions['_isCompositeFormElement'] = true
                )
            ) {
                continue;
            }

This was implicitly fixed for master in #81770.


Related issues

Related to TYPO3 Core - Bug #81770: EXT:form - do not show hidden field on confirmation page Closed 2017-07-03

Associated revisions

Revision 078aefbf (diff)
Added by Mathias Brodala about 1 year ago

[BUGFIX] EXT:form - fix composite element check

Resolves: #82518
Releases: 8.7
Change-Id: I889dc0d1293b65b8661ab5864acd5a89e9f18293
Reviewed-on: https://review.typo3.org/54182
Tested-by: TYPO3com <>
Reviewed-by: Bjoern Jacob <>
Tested-by: Bjoern Jacob <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Mathias Brodala about 1 year ago

  • Related to Bug #81770: EXT:form - do not show hidden field on confirmation page added

#2 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54182

#3 Updated by Mathias Brodala about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF