Bug #82833
closed
It's not possible to replace options from FinisherVariableProvider if they are floats
100%
Description
Currently only strings and integers are allowed. This prevents further values like floats from being used while saving to database.
The following implementation prevents such use case from working:
if (!is_string($value) && !is_int($value)) {
$value = '{' . $match[1] . '}';
}
https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_8-7/typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php#L208
To reproduce, register a custom finisher that will add a float and use this in another finisher like:
lat:
value: '{Geocode.result.geometry.location.lng}'
Updated by Daniel Siepmann over 6 years ago
Why at all should the return type be limited? Is this functionality only ment to be used for SaveToDatabase? Other finishers might work with arrays and even objects.
Updated by Mathias Brodala over 6 years ago
- Assignee set to Mathias Brodala
- Sprint Focus set to Remote Sprint
Updated by Gerrit Code Review over 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54994
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54994
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54994
Updated by Gerrit Code Review over 6 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55038
Updated by Mathias Brodala over 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 34cf1789be801ea36739af229e8baf4a76c7a49d.
Updated by