Bug #82898
closedEpic #82226: PHP 7.2
Declaration T3xDownloader::download not compatible (Composer 1.5.1/1.5.2)
100%
Description
PHP Fatal error: Declaration of
TYPO3\CMS\Composer\Installer\Downloader\T3xDownloader::download(Composer\Package\PackageInterface $package, $path)
must be compatible with
Composer\Downloader\ArchiveDownloader::download(Composer\Package\PackageInterface $package, $path, $output = true)
in [...]/typo3_src/vendor/typo3/cms-composer-installers/src/Installer/Downloader/T3xDownloader.php on line 27
Updated by Alexander Opitz over 7 years ago
Fixed with commit https://github.com/TYPO3/CmsComposerInstallers/commit/62f0b145cd52d0f8312411a61e3ef834a1e23c58
But how get this upgraded if it isn't compatible?
And TYPO3 8 LTS uses version 1.2.8 (latest is 1.4.4)
Updated by Helmut Hummel over 7 years ago
- Status changed from New to Needs Feedback
thanks for the report.
how does this affect TYPO3?
composer installations get the newest version of the installer and non composer based installations don't call anything from the installers anyway
but anyway it does not harm to update the lock file for the core
Updated by Gerrit Code Review over 7 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54567
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54567
Updated by Gerrit Code Review over 7 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54568
Updated by Alexander Opitz over 7 years ago
To work around this issue typo3/cms-composer-installers in version 1.4.5 was released.
HowTo Upgrade in this situation:
First update the plugin, while all plugins are disabled, then do the normal update as written in your(or TYPO3s) composer.lock file
$> composer require typo3/cms-composer-installers:^1.4 --no-plugins --update-no-dev $> composer install --no-dev
Updated by Helmut Hummel over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6885e191f145b166f88e60c360351147d69f640d.
Updated by Gerrit Code Review over 7 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54570
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54570
Updated by Alexander Opitz over 7 years ago
- Status changed from Under Review to Resolved
Applied in changeset f7cdd083e7d18b55141be047467f61aea854f7e2.
Updated by Gerrit Code Review over 7 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54601
Updated by Alexander Opitz over 7 years ago
- Status changed from Under Review to Resolved
Applied in changeset 3e871f80be2981fdc98a76d4c270b7712b00a98d.