Bug #82898: Declaration T3xDownloader::download not compatible (Composer 1.5.1/1.5.2) - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #82898

closed

Epic #82226: PHP 7.2

Declaration T3xDownloader::download not compatible (Composer 1.5.1/1.5.2)

Added by Alexander Opitz over 6 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

composer

Target version:

Start date:

2017-11-02

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.2

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

PHP Fatal error: Declaration of
TYPO3\CMS\Composer\Installer\Downloader\T3xDownloader::download(Composer\Package\PackageInterface $package, $path)
must be compatible with
Composer\Downloader\ArchiveDownloader::download(Composer\Package\PackageInterface $package, $path, $output = true)
in [...]/typo3_src/vendor/typo3/cms-composer-installers/src/Installer/Downloader/T3xDownloader.php on line 27

Actions

Copy link

Updated by Alexander Opitz over 6 years ago

Fixed with commit https://github.com/TYPO3/CmsComposerInstallers/commit/62f0b145cd52d0f8312411a61e3ef834a1e23c58

But how get this upgraded if it isn't compatible?

And TYPO3 8 LTS uses version 1.2.8 (latest is 1.4.4)

Actions

Copy link

Updated by Helmut Hummel over 6 years ago

Status changed from New to Needs Feedback

thanks for the report.
how does this affect TYPO3?

composer installations get the newest version of the installer and non composer based installations don't call anything from the installers anyway

but anyway it does not harm to update the lock file for the core

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from Needs Feedback to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54567

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54567

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54568

Actions

Copy link

Updated by Alexander Opitz over 6 years ago

To work around this issue typo3/cms-composer-installers in version 1.4.5 was released.

HowTo Upgrade in this situation:

First update the plugin, while all plugins are disabled, then do the normal update as written in your(or TYPO3s) composer.lock file

$> composer require typo3/cms-composer-installers:^1.4 --no-plugins --update-no-dev
$> composer install --no-dev

Actions

Copy link

Updated by Helmut Hummel over 6 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 6885e191f145b166f88e60c360351147d69f640d.

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54570

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54570

Actions

Copy link

#10

Updated by Alexander Opitz over 6 years ago

Status changed from Under Review to Resolved

Applied in changeset f7cdd083e7d18b55141be047467f61aea854f7e2.

Actions

Copy link

#11

Updated by Gerrit Code Review over 6 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54601

Actions

Copy link

#12