Bug #83006

L10nModeUpdater does not trigger custom language state

Added by Oliver Hader almost 2 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
DataHandler aka TCEmain
Target version:
-
Start date:
2017-11-15
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

L10nModeUpdater is used to migrate l10n_mode settings exclude and mergeIfNotBlank. In case mergeIfNotBlank is used, the localization state is set to custom if the according field value of the localized record is not empty (not blank). This state value is defined after DataMapProcessor has been executed - however, this information is essential for that processing. That's why the processing order has to be changed to:

  • determine l10n_state value (either "parent" or "custom")
  • execute DataMapProcessor & hand over the l10n_state (if available)
  • persist the result of the synchronization using DataHandler

Associated revisions

Revision 31fa79ce (diff)
Added by Helmut Hummel almost 2 years ago

[BUGFIX] Set l10n_state before synchronizing fields

L10nModeUpdater checks whether fields in translated records are
modified, thus not synchronized with the parent record and the
new l10n_state for this field is set to "custom" in this case
or "parent" if the field is empty.

However this is done after the data is synchronized, which
leads to wrong data being written by the DataMapProcessor.

To fix this, we move setting l10n_state upwards in the code,
so that relations and fields from translated records can be
updated correctly.

Resolves: #83006
Releases: master, 8.7
Change-Id: Ibb06eecb6cf743bd6bba1990ca6f9391c983821f
Reviewed-on: https://review.typo3.org/54657
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

Revision 693f270e (diff)
Added by Helmut Hummel almost 2 years ago

[BUGFIX] Set l10n_state before synchronizing fields

L10nModeUpdater checks whether fields in translated records are
modified, thus not synchronized with the parent record and the
new l10n_state for this field is set to "custom" in this case
or "parent" if the field is empty.

However this is done after the data is synchronized, which
leads to wrong data being written by the DataMapProcessor.

To fix this, we move setting l10n_state upwards in the code,
so that relations and fields from translated records can be
updated correctly.

Resolves: #83006
Releases: master, 8.7
Change-Id: Ibb06eecb6cf743bd6bba1990ca6f9391c983821f
Reviewed-on: https://review.typo3.org/54656
Tested-by: TYPO3com <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54656

#2 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54657

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54657

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54656

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54656

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54656

#7 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54657

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54657

#9 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54657

#10 Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54657

#11 Updated by Gerrit Code Review almost 2 years ago

Patch set 7 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54656

#12 Updated by Gerrit Code Review almost 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54657

#13 Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54656

#14 Updated by Helmut Hummel almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF