Task #83120

Epic #82226: PHP 7.2

TYPO3 7.6 support PHP 7.2

Added by Fabian Auer 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Code Cleanup
Start date:
2017-11-27
Due date:
% Done:

100%

Estimated time:
4.00 h
TYPO3 Version:
7
PHP Version:
7.2
Tags:
Complexity:
easy
Sprint Focus:
On Location Sprint

Description

PHP 7.2 ist not fully supported by TYPO3 7.6 yet.

Unit Test not working:
[27-Nov-2017 15:34:58 UTC] PHP Fatal error:  Declaration of SebastianBergmann\Comparator\DOMNodeComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false) must be compatible with SebastianBergmann\Comparator\ObjectComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false, array &$processed = Array) in /var/www/web/vendor/sebastian/comparator/src/DOMNodeComparator.php on line 110

Fatal error: Declaration of SebastianBergmann\Comparator\DOMNodeComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false) must be compatible with SebastianBergmann\Comparator\ObjectComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false, array &$processed = Array) in /var/www/web/vendor/sebastian/comparator/src/DOMNodeComparator.php on line 110

Backend Login breaks cause of missing condition for count() function.

Ticket as wrapper for all PHP 7.2 related fixeds in TYPO3 7.6.

Associated revisions

Revision e0ff86ab (diff)
Added by Christian Kuhn 3 months ago

[BUGFIX] phpunit: Update comparator from 1.2.2 to 1.2.4

Raising this indirect require-dev dependency fixes a
PHP 7.2 compatibility issue on core 7.6 branch:
"Declaration of DOMNodeComparator::assertEquals() must be
compatible with ..."

Change-Id: I1c422edab82250b51ae9a0cc268110c62977ee08
Resolves: #83195
Resolves: #83120
Releases: 7.6
Reviewed-on: https://review.typo3.org/54910
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Fabian Auer 3 months ago

  • Description updated (diff)

#2 Updated by Stephan Großberndt 3 months ago

#3 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54910

#4 Updated by Christian Kuhn 3 months ago

  • Parent task set to #82226

#5 Updated by Christian Kuhn 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF