Project

General

Profile

Actions
Copy link

Feature #83148

closed

Add Force download support to the FileDumpController

Added by Frans Saris almost 7 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Candidate for Major Version
Start date:
2017-11-28
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

The FileDumpController uses ResourceStorage::dumpFileContents() to dump the file. dumpFileContents() has a property so a Content-Disposition attachment header is sent, instead of inline.

But this option is currently not available when using the fildeDumpEID. A param &download=1 should be added to make this possible.

Actions
Copy link
 #1

Updated by Frans Saris almost 7 years ago

  • Complexity set to easy
Actions
Copy link
 #2

Updated by Susanne Moog about 6 years ago

  • Target version changed from 9 LTS to Candidate for Major Version
Actions
Copy link
 #3

Updated by Mathias Brodala about 6 years ago

AFAIS this could be implemented using the FileDumpEIDHookInterface and manually calling $file->getStorage()->streamFile($file, true);.

Actions
Copy link
 #4

Updated by Frans Saris about 6 years ago

Sure this is already possible by using the hook (like is done in ext:fal_securedownload).

But problem is that the hook will break other hooks registered after your hook that forces the download. Like a download counter.

That's why it would be a nice addition if the core would support the stream option.

Actions
Copy link
 #5

Updated by Stefan Froemken almost 5 years ago

Hi. I just see that we have this line in TYPO3 9 now:

return $file->getStorage()->streamFile($file);

So this Issue can be closed now, right?

Stefan

Actions
Copy link
 #6

Updated by Susanne Moog over 4 years ago

  • Status changed from New to Closed

Closed because of Stefans comment and no further feedback.

Actions
Copy link

Also available in: Atom PDF