Project

General

Profile

Actions
Copy link

Bug #83219

closed

Epic #90674: Backend UI not reflecting permissions

"Make new translation of this page" may create duplicate translations

Added by Christian Weiske over 6 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2017-12-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When TYPO3 is configured to have multiple page languages, a dropdown "Make new translation of this page" appears in the Web > Page "Languages" mode (see screenshot).

If two different editors have this open before a translation exists, and both then select "Make new translation of this page: English", both will create a new record in the page_language_overlay table.

This leads to hard to find bugs because the frontend will use one record while the backend allows one to edit the other one.

There should be a check that prevents such duplicates from appearing.

Files

2017-12-04 typo3 trans duplicate en.png (14.4 KB) 2017-12-04 typo3 trans duplicate en.png Christian Weiske, 2017-12-04 13:36
Actions
Copy link
 #1

Updated by Benni Mack almost 5 years ago

  • Status changed from New to Needs Feedback

Hey Christian,

sorry for the long delay!

we've merged "pages_language_overlay" into "pages" in v9, and did some heavy lifting in this area. Can you confirm this bug still exists? In addition, DataHandler checks for any existing translation when calling "localize()" which should overcome this issue as well.

Thanks for feedback!
Benni.

Actions
Copy link
 #2

Updated by Riccardo De Contardi about 4 years ago

Maybe the problem has been solved in version 9; I tried the following tests

Prerequisites

  1. Multilanguage installation with at least 2 languages (ITA, ENG )
  2. A BE Usergroup "Editors" with full ACL to all tables and fields
  3. two BE User "Editor" and "Editor2" that belongs to "Editors"
  4. A couple of pages in italian ("Test1", "Test2") that the users can edit

Test 1 Execution

  1. Open two different browsers and log in with "Editor" and "Editor2"
  2. Go to "Test1" page with both users > Page module > languages > try to use the "Make new translation of this page > English" dropdown

Result: If I try to use the "Make new translation of this page > English" dropdown, the new translated page is immediatly created, so they should really have to use it at the very same time to cause trouble

Test 2 Execution

  1. Open two different browsers and log in with "Editor" and "Editor2"
  2. Go to the parent page of "Test2" with both users > List module > Click on the icon to translate the page

Result: same as before, the page is created pretty instantaneously and the "slower" editor gets a couple of warning messages (first in red, second yellow):

1: Localization failed: there already are localizations (144) for language 1 of the "pages" record 126!

The BE-User 'editor' began to edit this record 0 min ago.

Do you think it is a sufficient test?

Actions
Copy link
 #3

Updated by Riccardo De Contardi about 4 years ago

  • Parent task set to #90674
Actions
Copy link
 #4

Updated by Christian Weiske about 4 years ago

  • % Done changed from 0 to 100

Thanks! That problem is solved now with TYPO3 v9.

Actions
Copy link
 #5

Updated by Riccardo De Contardi about 4 years ago

  • Status changed from Needs Feedback to Closed

@Christian Weiske thank you for your quick reply, I close this issue as solved

If you think that this is the wrong decision,please reopen it or ping me.

Actions
Copy link

Also available in: Atom PDF