Bug #83242

thumbnail is regenerated every time when empty processing configuration is passed

Added by Tymoteusz Motylewski almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2017-12-06
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Change https://review.typo3.org/53399 introduced a regression.

Thumbnail is regenerated every time process is called with
empty configuration like:

$fileObject->process(ProcessedFile::CONTEXT_IMAGEPREVIEW, []);

Steps to reproduce:
0. truncate processed files table
1. create empty folder
2. upload an image
3. upload same image again and wait for the modal to appear
4. cancel
5. goto 3 (edited)

processed file table is filled with same entries for every time the modal is shown


Related issues

Related to TYPO3 Core - Bug #81776: Duplicated image thumbnails in file list, file picker and search Closed 2017-07-03
Related to TYPO3 Core - Bug #83421: Fix preview processing API Closed 2017-12-24

Associated revisions

Revision 2f9cf149 (diff)
Added by Tymoteusz Motylewski almost 2 years ago

[BUGFIX] Do not reprocess image preview when empty configuration is passed

Fixes regression introduced in https://review.typo3.org/53399
Where thumbnail was regenerated every time process was called with
empty configuration like:

$fileObject->process(ProcessedFile::CONTEXT_IMAGEPREVIEW, [])

Resolves: #83242
Relates: #81776
Releases: master, 8.7, 7.6
Change-Id: I6a4c331bad4d80225d3914f1a48f6071b0d87380
Reviewed-on: https://review.typo3.org/54804
Tested-by: TYPO3com <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>

Revision 63d49e92 (diff)
Added by Tymoteusz Motylewski almost 2 years ago

[BUGFIX] Do not reprocess image preview when empty configuration is passed

Fixes regression introduced in https://review.typo3.org/53399
Where thumbnail was regenerated every time process was called with
empty configuration like:

$fileObject->process(ProcessedFile::CONTEXT_IMAGEPREVIEW, [])

Resolves: #83242
Relates: #81776
Releases: master, 8.7, 7.6
Change-Id: I6a4c331bad4d80225d3914f1a48f6071b0d87380
Reviewed-on: https://review.typo3.org/55039
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

Revision f7cafe6e (diff)
Added by Tymoteusz Motylewski almost 2 years ago

[BUGFIX] Do not reprocess image preview when empty configuration is passed

Fixes regression introduced in https://review.typo3.org/53399
Where thumbnail was regenerated every time process was called with
empty configuration like:

$fileObject->process(ProcessedFile::CONTEXT_IMAGEPREVIEW, [])

Resolves: #83242
Relates: #81776
Releases: master, 8.7, 7.6
Change-Id: I6a4c331bad4d80225d3914f1a48f6071b0d87380
Reviewed-on: https://review.typo3.org/55040
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

Revision c2c8790a (diff)
Added by Helmut Hummel almost 2 years ago

[TASK] Move changing preview processing config to processing service

Instead of complementing processing configuration in the file class,
move it to the processing service and LocalPreviewHelper class
to not have the code and logic duplicated and to ensure it is
always executed, not only when using the file API.

Resolves: #83421
Related: #81776
Related: #83242
Releases: master, 8.7, 7.6
Change-Id: I9b3f380625756137a56e7ad0ea55d21f47464ab8
Reviewed-on: https://review.typo3.org/55210
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

Revision 07ef3630 (diff)
Added by Helmut Hummel over 1 year ago

[TASK] Move changing preview processing config to processing service

Instead of complementing processing configuration in the file class,
move it to the processing service and LocalPreviewHelper class
to not have the code and logic duplicated and to ensure it is
always executed, not only when using the file API.

Resolves: #83421
Related: #81776
Related: #83242
Releases: master, 8.7, 7.6
Change-Id: I9b3f380625756137a56e7ad0ea55d21f47464ab8
Reviewed-on: https://review.typo3.org/55271
Tested-by: TYPO3com <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

Revision 4ab5437b (diff)
Added by Helmut Hummel over 1 year ago

[TASK] Move changing preview processing config to processing service

Instead of complementing processing configuration in the file class,
move it to the processing service and LocalPreviewHelper class
to not have the code and logic duplicated and to ensure it is
always executed, not only when using the file API.

Resolves: #83421
Related: #81776
Related: #83242
Releases: master, 8.7, 7.6
Change-Id: I9b3f380625756137a56e7ad0ea55d21f47464ab8
Reviewed-on: https://review.typo3.org/55270
Tested-by: TYPO3com <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54804

#2 Updated by Tymoteusz Motylewski almost 2 years ago

  • Related to Bug #81776: Duplicated image thumbnails in file list, file picker and search added

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55039

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55040

#5 Updated by Tymoteusz Motylewski almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Helmut Hummel almost 2 years ago

  • Related to Bug #83421: Fix preview processing API added

#7 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF