Bug #83322: AbstractNode::mergeChildReturnIntoExistingResult does not check empty fields before using foreach - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #83322

closed

AbstractNode::mergeChildReturnIntoExistingResult does not check empty fields before using foreach

Added by Wolfgang Klinger over 6 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Wolfgang Klinger

Category:

FormEngine aka TCEforms

Target version:

Start date:

2017-12-14

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

foreach ($childReturn['additionalJavaScriptPost'] as $value) {
            $existing['additionalJavaScriptPost'][] = $value;
}

… (4 occurrences)

so any custom Node has to return an array with all these elements even if not using them.

    public function render()
    {
        // all these fields are required
        $result = [
            'html' => 'Hello world!',

            'additionalJavaScriptPost' => [],
            'additionalJavaScriptSubmit' => [],
            'additionalHiddenFields' => [],
            'stylesheetFiles' => []
        ];

        return $result;
    }

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55066

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55066

Actions

Copy link

Updated by Christian Kuhn over 6 years ago

Ok to sanitize the merge method.

Note however that the code expects to initialize the result array using $this->initializeResultArray(). It is good practice to use that since this API method takes care of proper base array setup.

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55066

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55066

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55066

Actions

Copy link

Updated by Wolfgang Klinger over 6 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset adb73680e7b863897bb21efca37a96ed203da17c.

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55085

Actions

Copy link