Task #83417

Cannot click label to activate checkbox in Internet Explorer & Edge

Added by Mathias Brodala almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
Start date:
2017-12-22
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Checkbox fields of the form extension cannot be activated by clicking on their label in Internet Explorer and Edge.

This is a known and confirmed issue

Background for the bug:

The specs for the for attribute say:

If the for attribute is not specified, but the label element has a labelable element descendant, then the first such descendant in tree order is the label element’s labeled control.

The definition of a labelable element is:

... <input> (if the type attribute is not in the hidden state) ...

Internet Explorer and Edge ignore this and see the hidden input added to every checkbox field in Fluid forms as element to aim at.

Associated revisions

Revision 8ac3aebd (diff)
Added by Mathias Brodala almost 2 years ago

[BUGFIX] EXT:form - fix clicks on checkbox labels in IE/Edge

Add the "for" attribute to help Internet Explorer and Edge to target
the actual checkbox field, not the hidden field in front of it.

Resolves: #83417
Releases: master, 8.7
Change-Id: I603f95fc18df57f64d5dde8aefe6338c47b29536
Reviewed-on: https://review.typo3.org/55203
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision fc3c17d6 (diff)
Added by Benni Mack almost 2 years ago

[BUGFIX] EXT:form - fix clicks on checkbox labels in IE/Edge

Add the "for" attribute to help Internet Explorer and Edge to target
the actual checkbox field, not the hidden field in front of it.

Resolves: #83417
Releases: master, 8.7
Change-Id: I603f95fc18df57f64d5dde8aefe6338c47b29536
Reviewed-on: https://review.typo3.org/55661
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55203

#2 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55203

#3 Updated by Daniel Ruf almost 2 years ago

MultiCheckbox still needs an iterator + iterator.cycle per each for sequence as the uniqueIdentifier is always the same in the MultiCheckbox partial.
Same for RadioButton where each option needs another ID (as both traverse over the properties.options).

#4 Updated by Bjoern Jacob almost 2 years ago

  • Tracker changed from Bug to Feature
  • Target version changed from next-patchlevel to 9 LTS

Please see my comment on Gerrit:

IMHO this patch will cause new issues. This kinda feels like a feature. I would recommend not having template changes in v8 anymore. This caused too much trouble during the last minor releases of v8. Let's think of a more sophisticated solution for v9.

#5 Updated by Bjoern Jacob almost 2 years ago

  • Tracker changed from Feature to Task
  • TYPO3 Version set to 9

As decided on Gerrit, it is a TASK for v9 only.

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55203

#7 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55203

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55203

#9 Updated by Mathias Brodala almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55661

#11 Updated by Benni Mack almost 2 years ago

  • Status changed from Under Review to Resolved

#12 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF