Bug #83506

TS Condition on fe_user session data is not possible anymore

Added by Wolfgang Klinger 6 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Must have
Assignee:
-
Category:
TypoScript
Target version:
-
Start date:
2018-01-08
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

TS Condition on fe_user session data is not possible anymore,
because TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::$sessionData is protected now and there's no handling of a 'session:' key in ConditionMatcher:getVariable …

Benni Mack wrote: "Should also be applied to conditions!"
but this has been ignored in #80154

See also:
https://docs.typo3.org/typo3cms/extensions/core/Changelog/8.7/Feature-80154-RetrieveSessionDataInTS.html


Related issues

Related to TYPO3 Core - Bug #80154: Unserialized Session Data Variable is changed and protected since #70316 Closed 2017-03-06

Associated revisions

Revision c950cdef (diff)
Added by Wolfgang Klinger 5 months ago

[BUGFIX] Add possibility to use session data in TS conditions

Bring back the possibility to access FE session data in
TypoScript conditions:
[globalVar = TSFE:fe_user|sesData|some_key > 10]

Resolves: #83506
Releases: master, 8.7
Change-Id: I77f6bc73a6d9160b7074d39a948e94a59b51e521
Reviewed-on: https://review.typo3.org/55408
Tested-by: TYPO3com <>
Reviewed-by: Timo Pfeffer <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 7fea59aa (diff)
Added by Wolfgang Klinger 5 months ago

[BUGFIX] Add possibility to use session data in TS conditions

Bring back the possibility to access FE session data in
TypoScript conditions:
[globalVar = TSFE:fe_user|sesData|some_key > 10]

Resolves: #83506
Releases: master, 8.7
Change-Id: I77f6bc73a6d9160b7074d39a948e94a59b51e521
Reviewed-on: https://review.typo3.org/55557
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision c924fbda (diff)
Added by Wolfgang Klinger 4 months ago

[FEATURE] Add possibility to use session data in TS conditions

Since the session API has been adjusted it is no longer possible
to access the (now protected) sesData property of the fe_user object.
Using TSFE:fe_user|sesData|foo|bar in a TS condition will trigger
a deprecation log entry.

Instead a cleaner approach is now available:
[globalVar = session:foo|bar = 1234567]

Resolves: #83506
Releases: master
Change-Id: Idbb079334186eac1dfe062a71a601e556a9bd247
Reviewed-on: https://review.typo3.org/55310
Tested-by: TYPO3com <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Wolfgang Klinger 6 months ago

  • Related to Bug #80154: Unserialized Session Data Variable is changed and protected since #70316 added

#2 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#3 Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#4 Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#5 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55407

#6 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55408

#7 Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55407

#8 Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#9 Updated by Gerrit Code Review 5 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#10 Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55408

#11 Updated by Gerrit Code Review 5 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#12 Updated by Gerrit Code Review 5 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#13 Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55408

#14 Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55408

#15 Updated by Gerrit Code Review 5 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#16 Updated by Gerrit Code Review 5 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55408

#17 Updated by Gerrit Code Review 5 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#18 Updated by Gerrit Code Review 5 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55408

#19 Updated by Gerrit Code Review 5 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55408

#20 Updated by Gerrit Code Review 5 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55408

#21 Updated by Gerrit Code Review 5 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55408

#22 Updated by Gerrit Code Review 5 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55408

#23 Updated by Gerrit Code Review 5 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55408

#24 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55557

#25 Updated by Wolfgang Klinger 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#26 Updated by Gerrit Code Review 5 months ago

  • Status changed from Resolved to Under Review

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#27 Updated by Gerrit Code Review 4 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#28 Updated by Gerrit Code Review 4 months ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#29 Updated by Gerrit Code Review 4 months ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#30 Updated by Gerrit Code Review 4 months ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55310

#31 Updated by Wolfgang Klinger 4 months ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF