Project

General

Profile

Actions
Copy link

Bug #83611

closed

Linkvalidator wrongly handles Guzzle exceptions for 40x status

Added by Francois Suter almost 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Sybille Peters
Category:
Linkvalidator
Target version:
next-patchlevel
Start date:
2018-01-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

The linkvalidator tries to use HEAD requests to test URLs for external-type links. As this method may not be allowed, it falls back to GET.

This mechanism is broken since TYPO3 8, with the introduction of Guzzle, as Guzzle does not return a proper response with a status code in case of 40x errors. Instead it throws an exception, with the HTTP status code used as exception code.

The \TYPO3\CMS\Linkvalidator\Linktype\ExternalLinktype class needs to be adapted accordingly.

Actions
Copy link
 #1

Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55666

Actions
Copy link
 #2

Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55666

Actions
Copy link
 #3

Updated by Gerrit Code Review almost 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55666

Actions
Copy link
 #4

Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55678

Actions
Copy link
 #5

Updated by Sybille Peters almost 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Sybille Peters over 6 years ago

  • Status changed from Resolved to New
  • Assignee set to Sybille Peters

It seems this was not entirely resolved. The patch correctly handles the Guzzle exception but the behaviour should be:

Expected behaviour

If HEAD fails, try GET.

Current behaviour

What it does do currently: if HEAD fails (Exception is thrown) and Link is marked as broken.

Steps to reproduce

Create a link to a target with working link which will fail on HEAD, e.g.: https://www.retraitequebec.gouv.qc.ca/fr/Pages/accueil.aspx

Actions
Copy link
 #7

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57011

Actions
Copy link
 #8

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57011

Actions
Copy link
 #9

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57011

Actions
Copy link
 #10

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57011

Actions
Copy link
 #11

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57011

Actions
Copy link
 #12

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57011

Actions
Copy link
 #13

Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57011

Actions
Copy link
 #14

Updated by Gerrit Code Review over 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57011

Actions
Copy link
 #15

Updated by Gerrit Code Review over 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57011

Actions
Copy link
 #16

Updated by Gerrit Code Review over 6 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57011

Actions
Copy link
 #17

Updated by Gerrit Code Review over 6 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57011

Actions
Copy link
 #18

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57356

Actions
Copy link
 #19

Updated by Sybille Peters over 6 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #20

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF