Task #83966

Epic #83968: PSR-11 Initiative

Consolidate singleton usage

Added by Benjamin Franzke about 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
System/Bootstrap/Configuration
Target version:
Start date:
2018-02-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

There is Bootstrap::getInstance()->getEarlyInstance() and
GeneralUtility::makeInstance() to retrieve (global) instances.
Sometimes the former, sometimes the latter is used (e.g. to
retrieve the PackageManager).
As there is no obvious reason why diffrent methods are used, this
should be unified to one way to retrieve singletons.

Furthermore classes should not know whether something is an
early instance or not. Implementation details like that
should be abstracted into a singleton container.
That (currently) is GeneralUtility::makeInstance().

#1

Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55802

#2

Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55802

#3

Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55802

#4

Updated by Gerrit Code Review about 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55802

#5

Updated by Gerrit Code Review about 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55802

#6

Updated by Frank Naegler about 3 years ago

  • Parent task set to #83968
#7

Updated by Gerrit Code Review about 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55802

#8

Updated by Benjamin Franzke about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF