Task #83987

Remove extbase from view extension

Added by Georg Ringer about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2018-02-21
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #84697: Viewpage module throws localization error Closed 2018-04-12

Associated revisions

Revision 01a3d5a7 (diff)
Added by Georg Ringer almost 2 years ago

[TASK] Remove usage of extbase from viewpage module

Remove the overhead of extbase from the backend extension "viewpage".

Resolves: #83987
Releases: master
Change-Id: I3020aa7a9cffd92d4b96afd4d4044979a771db5b
Reviewed-on: https://review.typo3.org/55850
Reviewed-by: Benjamin Franzke <>
Tested-by: Benjamin Franzke <>
Tested-by: TYPO3com <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>

Revision fd8621d3 (diff)
Added by Benjamin Franzke almost 2 years ago

[TASK] Use PSR-7 request params in viewpage module

Since changeset I3020aa7a9cffd92d4b96afd4d4044979a771db5b
the viewpage module is a native PSR-7 controller, therefore
GeneralUtility _GP() and getIndpEnv() should no longer be used.

Restructure the code to use strict typing (to prevent type casting all
over the code), unify naming ($pageId and $languageId), and to prevent
calculating $targetUrl twice.

Releases: master
Resolves: #84015
Related: #83987
Change-Id: I4f2821824a6f811f4eebda7ebdaf09febab5eecc
Reviewed-on: https://review.typo3.org/55867
Tested-by: TYPO3com <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 2bb767c0 (diff)
Added by Andreas Fernandez almost 2 years ago

[BUGFIX] Set extension name in Fluid context

Resolves: #84697
Related: #83987
Releases: master
Change-Id: I292b5942144c1453921ba7ce490e26209dee187f
Reviewed-on: https://review.typo3.org/56635
Reviewed-by: Mathias Brodala <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Tested-by: TYPO3com <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55850

#2 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55850

#3 Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55850

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55850

#5 Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55850

#6 Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55850

#7 Updated by Georg Ringer almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Andreas Fernandez almost 2 years ago

  • Related to Bug #84697: Viewpage module throws localization error added

#9 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF