Task #84100
closedConnectionPool::getConnectionByName() should not be marked as "internal"
100%
Description
Currently this method is marked as internal and states that one should prefer to get the connection by table name. But there are valid (not-"edge") cases where one can not use the table name. For example, we have a project that exports data to foreign databases (which are not connected to our TYPO3 setup in any way). These databases are owned by different customers. These customers get a well-defined database scheme from us with the same(!) table names and columns - so we can not map a table name to a connection, but we map our external partners to connections. We use the ConnectionPool to manage the different database targets, but always get the "warning" while programming that this method is internal and should be avoided - which is pure cosmetic, admitedly, but still very wrong in our case.
Updated by Gerrit Code Review over 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55986
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55986
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55986
Updated by Gerrit Code Review over 6 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55989
Updated by Georg Ringer over 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 42a78bd9be414c54df47ca55506d48005e728a24.