Project

General

Profile

Actions

Bug #84170

closed

Inconsistent lib value in \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl() since GuzzleHttp switch

Added by Felix Buenemann over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2018-03-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

Since the conversion of \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl() from cURL to GuttleHttp in TYPO3 8 (see #70056), the return value for the lib ken in the $report is inconsistent between errors (Guzzle Exception) and other responses.

If an exception is captured the lib value returns GuzzleHttp (which is useful), in other cases it returns http (which is pretty non-descript).

The value should not change between a (captured) exception and a normal response, so I suggest always using GuzzleHttp, since the old value was cURL.

The proposed patch against master drops http, so GuzzleHttp is always returned. The patch also applies fine to the 8.7 branch with a line offset.


Files


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Feature #70056: Use guzzleClosedGeorg Ringer2015-09-23

Actions
Related to TYPO3 Core - Bug #84167: Negation Bug in TYPO3 8.7 GuzzleHttp \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl()ClosedMathias Schreiber2018-03-07

Actions
Actions #1

Updated by Felix Buenemann over 6 years ago

Actions #2

Updated by Felix Buenemann over 6 years ago

  • Related to Bug #84167: Negation Bug in TYPO3 8.7 GuzzleHttp \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl() added
Actions #3

Updated by Felix Buenemann over 6 years ago

  • File deleted (0001-BUGFIX-Inconsistent-lib-for-getUrl-GuzzleHttp.patch)
Actions #4

Updated by Felix Buenemann over 6 years ago

Updated paths in patch to match TYPO3.CMS repo instead of core subtree.

Actions #5

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56040

Actions #6

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56040

Actions #7

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56091

Actions #8

Updated by Felix Buenemann over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF