Bug #84170
closedInconsistent lib value in \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl() since GuzzleHttp switch
100%
Description
Since the conversion of \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl()
from cURL to GuttleHttp in TYPO3 8 (see #70056), the return value for the lib
ken in the $report
is inconsistent between errors (Guzzle Exception) and other responses.
If an exception is captured the lib
value returns GuzzleHttp
(which is useful), in other cases it returns http
(which is pretty non-descript).
The value should not change between a (captured) exception and a normal response, so I suggest always using GuzzleHttp
, since the old value was cURL
.
The proposed patch against master drops http
, so GuzzleHttp
is always returned. The patch also applies fine to the 8.7 branch with a line offset.
Files
Updated by Felix Buenemann over 6 years ago
- Related to Feature #70056: Use guzzle added
Updated by Felix Buenemann over 6 years ago
- Related to Bug #84167: Negation Bug in TYPO3 8.7 GuzzleHttp \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl() added
Updated by Felix Buenemann over 6 years ago
- File deleted (
0001-BUGFIX-Inconsistent-lib-for-getUrl-GuzzleHttp.patch)
Updated by Felix Buenemann over 6 years ago
- File 0001-BUGFIX-Inconsistent-lib-for-getUrl-GuzzleHttp.patch 0001-BUGFIX-Inconsistent-lib-for-getUrl-GuzzleHttp.patch added
Updated paths in patch to match TYPO3.CMS repo instead of core subtree.
Updated by Gerrit Code Review over 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56040
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56040
Updated by Gerrit Code Review over 6 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56091
Updated by Felix Buenemann over 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 54f807d70d3f5faf9e2e5470cb8358915a108314.