Project

General

Profile

Actions

Bug #84173

closed

TYPO3 8.7 GuzzleHttp \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl() returns content_type as array instead of string

Added by Felix Buenemann over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-03-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

There is a breaking change in the report format of \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl() introduced by the change form cURL to GuzzleHttp in #70056.

The old cURL based implementation returned the content_type in the $report as a string fetched via curl_getinfo(), but the new code uses $response->getHeader('Content-Type') which returns an array of strings.

In order to not break backward compatibility the code should use $response->getHeaderLine('Content-Type') instead.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Feature #70056: Use guzzleClosedGeorg Ringer2015-09-23

Actions
Related to TYPO3 Core - Bug #84167: Negation Bug in TYPO3 8.7 GuzzleHttp \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl()ClosedMathias Schreiber2018-03-07

Actions
Actions #1

Updated by Felix Buenemann over 6 years ago

Actions #2

Updated by Felix Buenemann over 6 years ago

  • Related to Bug #84167: Negation Bug in TYPO3 8.7 GuzzleHttp \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl() added
Actions #3

Updated by Felix Buenemann over 6 years ago

This is also related to #84167, since due to that bug the content_type was not returned in most cases (only for 300-400 status responses).

Actions #4

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56043

Actions #5

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56043

Actions #6

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56057

Actions #7

Updated by Felix Buenemann over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF