Project

General

Profile

Actions

Task #84237

closed

Update composer-dep nikic/php-parser to 4.0.0

Added by Stefan Neufeind about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-03-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

So far we had 3.1.1.

Actions #1

Updated by Gerrit Code Review about 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56128

Actions #2

Updated by Stefan Neufeind about 6 years ago

For a list of news/impact see:
https://github.com/nikic/PHP-Parser/blob/master/CHANGELOG.md

I don't foresee major changes for us. Let's maybe see what our tests and daily usage say.

Actions #3

Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56128

Actions #4

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56128

Actions #5

Updated by Anja Leichsenring about 6 years ago

The proposed update produces a different output than version 3 of the PHP parser:

v3:

object(PhpParser\Node\Expr\StaticCall)#582 (4) {
  ["class"]=>
  object(PhpParser\Node\Name\FullyQualified)#44 (2) {
    ["parts"]=>
    array(5) {
      [0]=>
      string(5) "TYPO3" 
      [1]=>
      string(3) "CMS" 
      [2]=>
      string(4) "Core" 
      [3]=>
      string(7) "Utility" 
      [4]=>
      string(14) "GeneralUtility" 
    }
    ["attributes":protected]=>
    array(2) {
      ["startLine"]=>
      int(2)
      ["endLine"]=>
      int(2)
    }
  }
  ["name"]=>
  string(12) "makeInstance" 
  ["args"]=>
  array(1) {
    [0]=>
    object(PhpParser\Node\Arg)#590 (4) {
      ["value"]=>
      object(PhpParser\Node\Name\FullyQualified)#581 (2) {
        ["parts"]=>
        array(5) {
          [0]=>
          string(5) "TYPO3" 
          [1]=>
          string(3) "CMS" 
          [2]=>
          string(4) "Does" 
          [3]=>
          string(3) "Not" 
          [4]=>
          string(5) "Exist" 
        }
        ["attributes":protected]=>
        array(3) {
          ["startLine"]=>
          int(2)
          ["endLine"]=>
          int(2)
          ["kind"]=>
          int(1)
        }
      }
      ["byRef"]=>
      bool(false)
      ["unpack"]=>
      bool(false)
      ["attributes":protected]=>
      array(2) {
        ["startLine"]=>
        int(2)
        ["endLine"]=>
        int(2)
      }
    }
  }
  ["attributes":protected]=>
  array(2) {
    ["startLine"]=>
    int(2)
    ["endLine"]=>
    int(2)
  }
}

v4:

object(PhpParser\Node\Stmt\Expression)#1102 (2) {
  ["expr"]=>
  object(PhpParser\Node\Expr\StaticCall)#1101 (4) {
    ["class"]=>
    object(PhpParser\Node\Name\FullyQualified)#1097 (2) {
      ["parts"]=>
      array(5) {
        [0]=>
        string(5) "TYPO3" 
        [1]=>
        string(3) "CMS" 
        [2]=>
        string(4) "Core" 
        [3]=>
        string(7) "Utility" 
        [4]=>
        string(14) "GeneralUtility" 
      }
      ["attributes":protected]=>
      array(2) {
        ["startLine"]=>
        int(2)
        ["endLine"]=>
        int(2)
      }
    }
    ["name"]=>
    object(PhpParser\Node\Identifier)#1098 (2) {
      ["name"]=>
      string(12) "makeInstance" 
      ["attributes":protected]=>
      array(2) {
        ["startLine"]=>
        int(2)
        ["endLine"]=>
        int(2)
      }
    }
    ["args"]=>
    array(1) {
      [0]=>
      object(PhpParser\Node\Arg)#1100 (4) {
        ["value"]=>
        object(PhpParser\Node\Scalar\String_)#1099 (2) {
          ["value"]=>
          string(24) "TYPO3\CMS\Does\Not\Exist" 
          ["attributes":protected]=>
          array(3) {
            ["startLine"]=>
            int(2)
            ["endLine"]=>
            int(2)
            ["kind"]=>
            int(1)
          }
        }
        ["byRef"]=>
        bool(false)
        ["unpack"]=>
        bool(false)
        ["attributes":protected]=>
        array(2) {
          ["startLine"]=>
          int(2)
          ["endLine"]=>
          int(2)
        }
      }
    }
    ["attributes":protected]=>
    array(2) {
      ["startLine"]=>
      int(2)
      ["endLine"]=>
      int(2)
    }
  }
  ["attributes":protected]=>
  array(2) {
    ["startLine"]=>
    int(2)
    ["endLine"]=>
    int(2)
  }
}

Actions #6

Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56128

Actions #7

Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56128

Actions #8

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56128

Actions #9

Updated by Gerrit Code Review almost 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56128

Actions #10

Updated by Stefan Neufeind almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF